TT-7061 going offline #202
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request addresses offline functionality issues (TT-7061) with several bug fixes and code quality improvements related to going offline.
Changes:
- Fixed Busy component rendering to avoid showing spinner when download alert is displayed
- Corrected global state access pattern in HeadStatus to use getGlobal() inside functions
- Adjusted timing of setBusy(false) call in ProjectDownload to prevent premature state updates
- Cleaned up code formatting and removed unnecessary eslint-disable comment
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| WSAudioPlayer.tsx | Code formatting: moved inline comment to separate line for better readability |
| ProjectDownloadAlert.tsx | Removed unnecessary eslint-disable comment for react-hooks/exhaustive-deps |
| ProjectDownload.tsx | Moved setBusy(false) call inside setTimeout to ensure proper timing after export completion |
| HeadStatus.tsx | Fixed cloudAction to use getGlobal('offline') instead of isOffline variable, following codebase convention for accessing state in functions |
| AppHead.tsx | Updated Busy component conditional rendering to check for downloadAlert, preventing spinner from showing during download alert display |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gtryus
requested changes
Feb 5, 2026
Contributor
gtryus
left a comment
gtryus
left a comment
There was a problem hiding this comment.
With DesktopToolbar and MobileToolbar extracted, shouldn't they each be in their own module?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.