Join Url paths with forward slashes instead of OS

[chrisvire]

• On Windows, the contents images had back slashes in paths intended for web pages and messed up the path processing.

Summary by CodeRabbit

• New Features

  • Added a URL-safe path-joining utility for consistent, web-friendly path construction.
  • Applied this utility across image, link, manifest, and stylesheet processing so generated URLs are built uniformly.

• Bug Fixes

  • Fixed inconsistent path formatting to ensure produced asset and link URLs are correctly structured for web use.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Warning

Rate limit exceeded

@chrisvire has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 11 minutes and 47 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📝 Walkthrough

Walkthrough

Adds an exported joinUrlPath(...parts: string[]) in convert/fileUtils.ts (uses path.posix) and updates multiple converters to build URL-style paths with it instead of manual string concatenation or join().

Changes

Cohort / File(s)	Summary
URL join utility convert/fileUtils.ts	Adds exported joinUrlPath(...parts: string[]) using path.posix. Replaces join() usage when computing hashedPath in createHashedFile and createHashedFileFromContents.
Book conversion image handling convert/convertBooks.ts	Imports joinUrlPath and replaces manual ${base}/${imagePath} and fileName concatenation with joinUrlPath('illustrations', fileName) and joinUrlPath(base, imagePath).
Content link construction convert/convertContents.ts	Adds joinUrlPath import, tightens a truthiness check for linkTarget, and replaces string interpolation for linkLocation with joinUrlPath(linkType, collection.id, linkTarget).
Manifest path update convert/convertManifest.ts	Imports joinUrlPath and replaces literal "./<name>" replacement with joinUrlPath('.', <name>) when updating manifest src.
Styles / fonts path replacement convert/convertStyles.ts	Imports joinUrlPath and replaces line.replace('/fonts', \$assets/${finalPath}`)withline.replace('/fonts', joinUrlPath('$assets', finalPath))`.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 I hop on paths with perfect slash,
POSIX trails avoid a clash.
joinUrlPath threads each file through,
Neat URLs, all fresh and new. 🥕✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 22.22% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The pull request title directly addresses the main change: introducing URL-safe path joining with forward slashes instead of OS-dependent separators, which is the core objective across all modified files.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In `@convert/fileUtils.ts`:
- Around line 79-82: joinUrlPath currently calls posix.join(...parts) but does
not normalize Windows backslashes, so segments containing '\' will be preserved;
update joinUrlPath to first map over the incoming parts and replace all
backslashes with forward slashes (e.g., part.replace(/\\/g, '/')) before calling
posix.join, ensuring any trailing/leading backslashes are normalized to POSIX
separators and the returned path is always POSIX-style; keep the function name
joinUrlPath and the posix.join call but feed it the normalized segments.