Skip to content

Hide audio download controls - not implemented#935

Merged
chrisvire merged 1 commit intosillsdev:mainfrom
chrisvire:fix/hide-downloads
Jan 30, 2026
Merged

Hide audio download controls - not implemented#935
chrisvire merged 1 commit intosillsdev:mainfrom
chrisvire:fix/hide-downloads

Conversation

@chrisvire
Copy link
Member

@chrisvire chrisvire commented Jan 30, 2026

Summary by CodeRabbit

  • Chores
    • Disabled offline audio-related features including audio access method, video access method, and audio download mode. These features are marked as not implemented.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 30, 2026

📝 Walkthrough

Walkthrough

The change modifies convert/convertConfig.ts by adding five lines that set three offline audio-related feature flags to false within the filterFeaturesNotReady function. These flags—settings-audio-access-method, settings-video-access-method, and settings-audio-download-mode—are marked as not implemented.

Changes

Cohort / File(s) Summary
Offline Audio Features
convert/convertConfig.ts
Explicitly disables three offline audio-related features (settings-audio-access-method, settings-video-access-method, and settings-audio-download-mode) in filterFeaturesNotReady function.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🎤 Audio dreams are disabled today,
Three feature flags tucked safe away,
The rabbit coder hops with glee,
Converting configs happily! 🐰

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: disabling audio download controls in the feature configuration by marking them as not implemented.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@chrisvire chrisvire merged commit 000c798 into sillsdev:main Jan 30, 2026
4 checks passed
@chrisvire chrisvire deleted the fix/hide-downloads branch January 30, 2026 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant