fix login fwlite web #1338
Merged
fix login fwlite web #1338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ased login to support more then one request and cancel requests that hang for 5 minutes
… fails to start when both the build and server are started at once due to the missing js files
Contributor
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
login from FwLiteWeb was not working correctly because the frontend code was always trying to use the SystemWebView which it can't do from the web. There's also been a long standing issue of only 1 login attempt being possible at a time and if that login attempt was abandoned then the whole server needed to be restarted. Now that's been fixed and it will cancel abandoned logins after 5 minutes