Generalize writing system font patch to include vernacular

[myieye]

The font patch method was only handling Analysis writing systems, but Vernacular writing systems also sometimes use different fonts on Windows (e.g. seh is defaulting to Doulos for me). Renamed and updated the method to patch all writing systems to ensure consistent snapshot verification across platforms.

https://claude.ai/code/session_fx7MS

[coderabbitai]

📝 Walkthrough

Walkthrough

A private helper method is renamed from PatchAnalysisWsFontsWithCharisSIL to PatchAllWsFontsWithCharisSIL, and its scope is expanded to patch both Analysis and Vernacular writing systems with Charis SIL font. The previous assertion for exactly two Analysis writing systems is replaced with iterative patching logic.

Changes

Cohort / File(s)	Summary
Test Utility Refactoring backend/FwLite/FwLiteProjectSync.Tests/Sena3SyncTests.cs	Renamed private helper method and extended font-patching logic from Analysis-only writing systems to all writing systems (Analysis and Vernacular). Removed specific assertion and replaced with loop-based font standardization across all applicable items.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐰 A helper hops with broader sight,
Patching all fonts left and right,
From Analysis to Vernacular's way,
Charis SIL lights up the day! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely describes the main change: generalizing the font patch method to include vernacular writing systems alongside analysis writing systems.
Description check	✅ Passed	The description is directly related to the changeset, explaining the motivation for the change and the specific problem being addressed with vernacular fonts on Windows.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[argos-ci]

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build	Status	Details	Updated (UTC)
default (Inspect)	✅ No changes detected	-	Jan 29, 2026, 12:25 PM

[github-actions]

UI unit Tests

  1 files   47 suites   18s ⏱️
123 tests 123 ✅ 0 💤 0 ❌
184 runs  184 ✅ 0 💤 0 ❌

Results for commit c4ca9b4.