DEP Allow multiple versions of sebastian/diff #11959
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Member
|
Converting to draft pending discussion about whether we should even do this - which we'll have on the issue. |
emteknetnz
force-pushed
the
pulls/6/multi-diff
branch
from
12f9521 to
4f5d92f
Compare
emteknetnz
commented
Feb 12, 2026
| } | ||
|
|
||
| #[DataProvider('provideLineEndingCompatibility')] | ||
| public function testLineEndingCompatibility(string $from, string $to, bool $escape, string $expected): void |
Member
Author
There was a problem hiding this comment.
This test was added for a little additional test coverage, though it won't materially change the risk of allow additional versions of the diff module as we only test against a single major in CI
emteknetnz
force-pushed
the
pulls/6/multi-diff
branch
from
4f5d92f to
be635bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #11958
Targeting next minor as it's a dep change
This dep is not a fixed dependency
Should install the following:
IDK - I'm in 2 minds about this one. Looks like there is difference between 6.0.2 and 7.0.0 - https://github.com/sebastianbergmann/diff/compare/6.0.2..7.0.0 - I'm inclined to not merge this