Open
Conversation
Owner
|
Hey @jopech-tibco, that is really cool! Yeah this library is quite "old" and could go with some unit tests, I'll definitely have a look at it the coming days ❤️ Hell, playwright and vitest didn't even exist when I first created it 😅 |
Author
|
Could be quite old, but its really cool and useful |
jopech-tibco
force-pushed
the
unit-tests
branch
from
811018f to
3ea675d
Compare
Owner
|
Alright, I'm gonna keep this PR open for a while until I added a GitHub workflow and maybe a few more tests. I really like this Idea but don't have that much time at hand right now, but thank you for bringing this up. Been using vitest and playwright for years at work but kinda forgot about the projects of my own haha :D I should probably set up something like prettier as well and migrate ESLint to v9 ugh... |
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added small unit test for checking that selection is working. This is a POC, but could be really helpful to have UT in place @simonwep
I used @testing-library/dom for simulating mousedown/mousemove/mouseup
How to run?
npx lerna run test --scope @viselect/vanillaDeps added: