Check constant exists instead of rescuing#53
Merged
Conversation
Contributor
Author
|
/dobby version patch |
tsarupinda
approved these changes
Aug 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the logic for creating record classes in
lib/rulezilla/dsl.rbto improve code organization and readability. The main change is breaking up the monolithiccreate_klassmethod into smaller, single-responsibility methods. This makes the code easier to maintain and understand, while also refining how support modules are included.Refactoring and code organization:
create_klassmethod into three distinct methods:create_record_class,setup_record_class, anddefine_record_methods, each handling a specific part of the record class creation process.Object.const_defined?) before including, preventing unnecessary exceptions if the module does not exist.Visibility and method encapsulation:
create_record_class,setup_record_class,define_record_methods) to the list of private class methods, ensuring proper encapsulation and restricting their access to internal use only.@simplybusiness/palm-trees