-
Notifications
You must be signed in to change notification settings - Fork 3.3k
feat(ee): add enterprise edition module structure #3121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Greptile OverviewGreptile SummaryThis PR moves enterprise features (SSO, access control/permission groups, credential sets) into a dedicated Most changes are path-only moves/renames with minimal logic churn. Notable behavior changes are limited to:
Confidence Score: 3/5
Important Files Changed
Sequence DiagramsequenceDiagram
autonumber
participant UI as UI (Next.js pages)
participant EE as Enterprise modules (@/ee)
participant API as Next.js Route Handlers
participant AC as Access Control utils/hooks
participant Auth as Auth/session
participant Exec as Executor (blocks/handlers)
UI->>EE: Import SSO/AccessControl/Credential Sets components
UI->>API: Call workspace/org invitation endpoints
API->>Auth: Resolve user/session
API->>AC: Check permissions / permission groups
AC-->>API: Allow/deny
API-->>UI: Invitation response
UI->>Exec: Trigger workflow execution
Exec->>EE: Load EE block/tool metadata (if referenced)
Exec-->>UI: Return execution output/status
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4 files reviewed, 3 comments
...orkspace/[workspaceId]/w/components/sidebar/components/settings-modal/components/mcp/mcp.tsx
Outdated
Show resolved
Hide resolved
|
@greptile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
41 files reviewed, 3 comments
Additional Comments (1)
If the Prompt To Fix With AIThis is a comment left during a code review.
Path: apps/sim/ee/access-control/components/access-control.tsx
Line: 548:553
Comment:
`handleOpenAddMembersModal`’s callback now has an empty dependency array, but it reads `members` (for `existingMemberUserIds`) in the previous version. If `members` is expected to affect modal state (e.g. to precompute/avoid re-adding existing members), removing this dependency can freeze behavior to the initial render or drop the intended logic.
If the `existingMemberUserIds` computation is truly unused, consider removing it entirely (including any downstream expectations). Otherwise, restore the dependency on `members` (and any derived values used in the callback).
How can I resolve this? If you propose a fix, please make it concise. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
…3118) * fix(formatting): consolidate duration formatting into shared utility * fix(formatting): preserve original precision and rounding behavior * fix(logs): add precision to logs list duration formatting * fix(formatting): use parseFloat to preserve fractional milliseconds * feat(ee): add enterprise modules (#3121) * fix(formatting): return null for missing values, strip trailing zeros
Summary
ee/directory@/ee/...directlyType of Change
Testing
Build passes, tested manually
Checklist