fix: make curl requests failsafe against redirects, return error on fail#229
Merged
vsoch merged 2 commits intosingularityhub:masterfrom Dec 13, 2025
Merged
fix: make curl requests failsafe against redirects, return error on fail#229vsoch merged 2 commits intosingularityhub:masterfrom
vsoch merged 2 commits intosingularityhub:masterfrom
Conversation
Member
|
Thanks! Could you please add a line to the changelog and bump the version in version.py? |
vsoch
approved these changes
Dec 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #228. A small change that makes the
curldownload requests more failsafe, handling redirection and returning a clear error message if the target is not available.