Add screenshot functionality #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the menu entry and a stub method, wired up but not yet implemented. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Import QFileDialog - Grab QPixmap from the display item at native camera resolution - Copy to clipboard immediately via QApplication.clipboard() - Open a save dialog defaulting to ~/kvm_screenshot_<timestamp>.png - Show confirmation dialogs for save, save-failure, or clipboard-only Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Add QFileDialog to mocked widgets in test base - Test no-frame warning, None pixmap, clipboard copy, file save success/failure, dialog cancellation, default filename format, and None clipboard handling Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #27 +/- ##
==========================================
+ Coverage 77.98% 78.25% +0.26%
==========================================
Files 19 19
Lines 1731 1752 +21
Branches 210 214 +4
==========================================
+ Hits 1350 1371 +21
Misses 381 381
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
~/kvm_screenshot_<timestamp>.pngDetails
The
QPixmapis grabbed directly from theQGraphicsPixmapItemwhich holds the frame at the camera's native resolution —QGraphicsView.fitInView()only scales the view, not the underlying pixmap — so the screenshot bypasses any window-size-dependent scaling.No new dependencies.
QPixmap.save()handles PNG natively andQApplication.clipboard()is already used for paste.Test plan
test_kvm_screenshot.pycovering: