Pullrequest thunderbird zero duration workaround#147
Open
JoachimFalk wants to merge 2 commits intoskarim:masterfrom
Open
Pullrequest thunderbird zero duration workaround#147JoachimFalk wants to merge 2 commits intoskarim:masterfrom
JoachimFalk wants to merge 2 commits intoskarim:masterfrom
Conversation
Thunderbird (Lightning calendar) sometimes generates a VEVENT with a zero DURATION entry while DTEND is also present. This can happen if you edit one event belonging to a series of recurring events.
…Lightning Fixed exception 'vobject.base.ValidateError: 'VEVENT components cannot contain both DTEND and DURATION components' triggered by bad ics files generated by Thunderbird (Lightning calendar) where sometimes a zero DURATION entry can be present even if DTEND was given. The patch will delete such redundant zero DURATION entries.
Collaborator
|
@JoachimFalk do you know if there's a Mozilla bug for this? I had a quick search in their Bugzilla, but didn't turn up anything. |
Author
|
@da4089 I don't know and I also did not submit one to Mozilla. Maybe they fixed the bug in the meantime. At the moment, I can't reproduce it. The bug was there ca. around Aug. 2019. |
Collaborator
|
Some maybe it's been fixed in the last ... err ... 5 years. |
Collaborator
|
@JoachimFalk, I'll skip merging this into the https://github.com/py-vobject/vobject repo on the basis that you cannot repro it. If you come across this problem again, please raise an issue there, and link back to this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Work around for DTEND and DURATION presence generated by Thunderbird Lightning
Author: Joachim Falk joachim.falk@gmx.de
Thunderbird (Lightning calendar) sometimes generates a VEVENT with
a zero DURATION entry while DTEND is also present. This can happen if
you edit one event belonging to a series of recurring events.
Fixed exception
'vobject.base.ValidateError: 'VEVENT components cannot contain both
DTEND and DURATION components'
triggered by bad ics files generated by Thunderbird (Lightning calendar)
where sometimes a zero DURATION entry can be present even if DTEND was
given. The patch will delete such redundant zero DURATION entries.