Skip to content

Allow additional arguments to be passed through serialize() #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
akuker wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow additional arguments to be passed through serialize() #191

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions vobject/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@ def transformChildrenFromNative(self, clearBehavior=True):
"""
pass

def serialize(self, buf=None, lineLength=75, validate=True, behavior=None):
def serialize(self, buf=None, lineLength=75, validate=True, behavior=None, *args, **kwargs):
"""
Serialize to buf if it exists, otherwise return a string.

Expand All @@ -251,7 +251,7 @@ def serialize(self, buf=None, lineLength=75, validate=True, behavior=None):
if behavior:
if DEBUG:
logger.debug("serializing {0!s} with behavior {1!s}".format(self.name, behavior))
return behavior.serialize(self, buf, lineLength, validate)
return behavior.serialize(self, buf, lineLength, validate, *args, **kwargs)
else:
if DEBUG:
logger.debug("serializing {0!s} without behavior".format(self.name))
Expand Down
2 changes: 1 addition & 1 deletion vobject/behavior.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ def generateImplicitParameters(cls, obj):
pass

@classmethod
def serialize(cls, obj, buf, lineLength, validate=True):
def serialize(cls, obj, buf, lineLength, validate=True, *args, **kwargs):
"""
Set implicit parameters, do encoding, return unicode string.

Expand Down
5 changes: 2 additions & 3 deletions vobject/vcard.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,16 +226,15 @@ def valueRepr(cls, line):
return " (BINARY PHOTO DATA at 0x{0!s}) ".format(id(line.value))

@classmethod
def serialize(cls, obj, buf, lineLength, validate):
def serialize(cls, obj, buf, lineLength, validate, *args, **kwargs):
"""
Apple's Address Book is *really* weird with images, it expects
base64 data to have very specific whitespace. It seems Address Book
can handle PHOTO if it's not wrapped, so don't wrap it.
"""
if wacky_apple_photo_serialize:
lineLength = REALLY_LARGE
VCardTextBehavior.serialize(obj, buf, lineLength, validate)

VCardTextBehavior.serialize(obj, buf, lineLength, validate, *args, **kwargs)
registerBehavior(Photo)


Expand Down