-
-
Notifications
You must be signed in to change notification settings - Fork 383
task: style to tailwind #4162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
task: style to tailwind #4162
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| --- | ||
| "@skeletonlabs/skeleton-common": patch | ||
| "@skeletonlabs/skeleton-svelte": patch | ||
| "@skeletonlabs/skeleton-react": patch | ||
| --- | ||
|
|
||
| task: Convert CSS variables from `style` expressions to `tailwind` classes | ||
|
|
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -15,12 +15,7 @@ function Page() { | |||||
| <Tooltip.Positioner> | ||||||
| <Tooltip.Content> | ||||||
| Content | ||||||
| <Tooltip.Arrow | ||||||
| style={{ | ||||||
| ['--arrow-size' as string]: 'calc(var(--spacing) * 2)', | ||||||
| ['--arrow-background' as string]: 'var(--color-surface-100-900)', | ||||||
| }} | ||||||
| > | ||||||
| <Tooltip.Arrow className="[--arrow-size:--spacing(2)] [--arrow-background:var(--color-surface-100-900)]"> | ||||||
|
||||||
| <Tooltip.Arrow className="[--arrow-size:--spacing(2)] [--arrow-background:var(--color-surface-100-900)]"> | |
| <Tooltip.Arrow className="[--arrow-size:calc(var(--spacing)*2)] [--arrow-background:var(--color-surface-100-900)]"> |
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -13,7 +13,7 @@ | |||||
| nesciunt enim. | ||||||
| </Popover.Description> | ||||||
| <Popover.CloseTrigger class="btn preset-tonal">Close</Popover.CloseTrigger> | ||||||
| <Popover.Arrow style="--arrow-size: calc(var(--spacing) * 2); --arrow-background: var(--color-surface-100-900);"> | ||||||
| <Popover.Arrow class="[--arrow-size:--spacing(2)] [--arrow-background:var(--color-surface-100-900)]"> | ||||||
|
||||||
| <Popover.Arrow class="[--arrow-size:--spacing(2)] [--arrow-background:var(--color-surface-100-900)]"> | |
| <Popover.Arrow class="[--arrow-size:calc(var(--spacing)*2)] [--arrow-background:var(--color-surface-100-900)]"> |
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -8,7 +8,7 @@ | |||||
| <Tooltip.Positioner> | ||||||
| <Tooltip.Content> | ||||||
| Content | ||||||
| <Tooltip.Arrow style="--arrow-size: calc(var(--spacing) * 2); --arrow-background: var(--color-surface-100-900);"> | ||||||
| <Tooltip.Arrow class="[--arrow-size:--spacing(2)] [--arrow-background:var(--color-surface-100-900)]"> | ||||||
|
||||||
| <Tooltip.Arrow class="[--arrow-size:--spacing(2)] [--arrow-background:var(--color-surface-100-900)]"> | |
| <Tooltip.Arrow class="[--arrow-size:calc(var(--spacing)*2)] [--arrow-background:var(--color-surface-100-900)]"> |
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -49,12 +49,7 @@ export default function Anchor() { | |||||
| </p> | ||||||
| </div> | ||||||
| </div> | ||||||
| <Popover.Arrow | ||||||
| style={{ | ||||||
| ['--arrow-size' as string]: 'calc(var(--spacing) * 2)', | ||||||
| ['--arrow-background' as string]: 'var(--color-surface-100-900)', | ||||||
| }} | ||||||
| > | ||||||
| <Popover.Arrow className="[--arrow-size:--spacing(2)] [--arrow-background:var(--color-surface-100-900)]"> | ||||||
|
||||||
| <Popover.Arrow className="[--arrow-size:--spacing(2)] [--arrow-background:var(--color-surface-100-900)]"> | |
| <Popover.Arrow className="[--arrow-size:calc(var(--spacing)*2)] [--arrow-background:var(--color-surface-100-900)]"> |
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -8,12 +8,7 @@ export default function Arrow() { | |||||
| <Popover.Positioner> | ||||||
| <Popover.Content className="card max-w-md p-4 bg-surface-100-900 shadow-xl"> | ||||||
| <Popover.Description>This example will have a small arrow.</Popover.Description> | ||||||
| <Popover.Arrow | ||||||
| style={{ | ||||||
| ['--arrow-size' as string]: 'calc(var(--spacing) * 2)', | ||||||
| ['--arrow-background' as string]: 'var(--color-surface-100-900)', | ||||||
| }} | ||||||
| > | ||||||
| <Popover.Arrow className="[--arrow-size:--spacing(2)] [--arrow-background:var(--color-surface-100-900)]"> | ||||||
|
||||||
| <Popover.Arrow className="[--arrow-size:--spacing(2)] [--arrow-background:var(--color-surface-100-900)]"> | |
| <Popover.Arrow className="[--arrow-size:calc(var(--spacing)*2)] [--arrow-background:var(--color-surface-100-900)]"> |
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -39,12 +39,7 @@ export default function Default() { | |||||
| </p> | ||||||
| </div> | ||||||
| </div> | ||||||
| <Popover.Arrow | ||||||
| style={{ | ||||||
| ['--arrow-size' as string]: 'calc(var(--spacing) * 2)', | ||||||
| ['--arrow-background' as string]: 'var(--color-surface-100-900)', | ||||||
| }} | ||||||
| > | ||||||
| <Popover.Arrow className="[--arrow-size:--spacing(2)] [--arrow-background:var(--color-surface-100-900)]"> | ||||||
|
||||||
| <Popover.Arrow className="[--arrow-size:--spacing(2)] [--arrow-background:var(--color-surface-100-900)]"> | |
| <Popover.Arrow className="[--arrow-size:calc(var(--spacing)*2)] [--arrow-background:var(--color-surface-100-900)]"> |
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -41,7 +41,7 @@ | |||||
| <p class="text-sm">100 <span class="opacity-60">Posts</span></p> | ||||||
| </div> | ||||||
| </div> | ||||||
| <Popover.Arrow style="--arrow-size: calc(var(--spacing) * 2); --arrow-background: var(--color-surface-100-900);"> | ||||||
| <Popover.Arrow class="[--arrow-size:--spacing(2)] [--arrow-background:var(--color-surface-100-900)]"> | ||||||
|
||||||
| <Popover.Arrow class="[--arrow-size:--spacing(2)] [--arrow-background:var(--color-surface-100-900)]"> | |
| <Popover.Arrow class="[--arrow-size:calc(var(--spacing)*2)] [--arrow-background:var(--color-surface-100-900)]"> |
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -8,7 +8,7 @@ | |||||
| <Popover.Positioner> | ||||||
| <Popover.Content class="card max-w-md p-4 bg-surface-100-900 shadow-xl"> | ||||||
| <Popover.Description>This example will have a small arrow.</Popover.Description> | ||||||
| <Popover.Arrow style="--arrow-size: calc(var(--spacing) * 2); --arrow-background: var(--color-surface-100-900);"> | ||||||
| <Popover.Arrow class="[--arrow-size:--spacing(2)] [--arrow-background:var(--color-surface-100-900)]"> | ||||||
|
||||||
| <Popover.Arrow class="[--arrow-size:--spacing(2)] [--arrow-background:var(--color-surface-100-900)]"> | |
| <Popover.Arrow class="[--arrow-size:calc(var(--spacing)*2)] [--arrow-background:var(--color-surface-100-900)]"> |
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -31,7 +31,7 @@ | |||||
| <p class="text-sm">100 <span class="opacity-60">Posts</span></p> | ||||||
| </div> | ||||||
| </div> | ||||||
| <Popover.Arrow style="--arrow-size: calc(var(--spacing) * 2); --arrow-background: var(--color-surface-100-900);"> | ||||||
| <Popover.Arrow class="[--arrow-size:--spacing(2)] [--arrow-background:var(--color-surface-100-900)]"> | ||||||
|
||||||
| <Popover.Arrow class="[--arrow-size:--spacing(2)] [--arrow-background:var(--color-surface-100-900)]"> | |
| <Popover.Arrow class="[--arrow-size:calc(var(--spacing)*2)] [--arrow-background:var(--color-surface-100-900)]"> |
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -6,14 +6,9 @@ export default function Arrow() { | |||||
| <Tooltip.Trigger>Hover</Tooltip.Trigger> | ||||||
| <Portal> | ||||||
| <Tooltip.Positioner> | ||||||
| <Tooltip.Content className="card bg-surface-100-900 p-2 shadow-xl"> | ||||||
| <Tooltip.Content className="card bg-surface-100-900 p-2 shadow-xl"> | ||||||
| <span>Hello Skeleton</span> | ||||||
| <Tooltip.Arrow | ||||||
| style={{ | ||||||
| ['--arrow-size' as string]: 'calc(var(--spacing) * 2)', | ||||||
| ['--arrow-background' as string]: 'var(--color-surface-100-900)', | ||||||
| }} | ||||||
| > | ||||||
| <Tooltip.Arrow className="[--arrow-size:--spacing(2)] [--arrow-background:var(--color-surface-100-900)]"> | ||||||
|
||||||
| <Tooltip.Arrow className="[--arrow-size:--spacing(2)] [--arrow-background:var(--color-surface-100-900)]"> | |
| <Tooltip.Arrow className="[--arrow-size:calc(var(--spacing)*2)] [--arrow-background:var(--color-surface-100-900)]"> |
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -6,9 +6,9 @@ | |||||
| <Tooltip.Trigger>Hover</Tooltip.Trigger> | ||||||
| <Portal> | ||||||
| <Tooltip.Positioner> | ||||||
| <Tooltip.Content class="card bg-surface-100-900 p-2 shadow-xl"> | ||||||
| <Tooltip.Content class="card bg-surface-100-900 p-2 shadow-xl"> | ||||||
| <span>Hello Skeleton</span> | ||||||
| <Tooltip.Arrow style="--arrow-size: calc(var(--spacing) * 2); --arrow-background: var(--color-surface-100-900);"> | ||||||
| <Tooltip.Arrow class="[--arrow-size:--spacing(2)] [--arrow-background:var(--color-surface-100-900)]"> | ||||||
|
||||||
| <Tooltip.Arrow class="[--arrow-size:--spacing(2)] [--arrow-background:var(--color-surface-100-900)]"> | |
| <Tooltip.Arrow class="[--arrow-size:calc(var(--spacing)*2)] [--arrow-background:var(--color-surface-100-900)]"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incorrect Tailwind arbitrary CSS variable syntax. The syntax
[--arrow-size:--spacing(2)]is invalid. It should be[--arrow-size:calc(var(--spacing)*2)]to match the originalcalc(var(--spacing) * 2)value, or use a direct pixel/spacing value. The--spacing(2)function-like syntax is not valid CSS.