Add index paramter to toast for proper overlap styling#4268
Add index paramter to toast for proper overlap styling#4268endigo9740 merged 9 commits intoskeletonlabs:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 00a4c01 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
There was a problem hiding this comment.
@cmintey See my comment below.
And one additional note - I'm going to run this by @Hugos68. As he has a much better handle on the inner workings of Zag. There's two things I'm going to ask of him:
- Does he agree with my suggested implementation
- Should we consider sending this upstream in some capacity to Zag; perhaps they can implement a change that makes this even more trivial
In the meantime, let's go ahead and make the changes as I describe below. And as I stated - if it's easier to start with a fresh PR, by all means close this one out. I'd understand given the number of changes.
packages/skeleton-svelte/src/components/toast/anatomy/group.svelte
Outdated
Show resolved
Hide resolved
This reverts commit 8a84b6b.
There was a problem hiding this comment.
@cmintey again thanks for the quick turn around. Just two super minor things. If need be I can jump in and help with these, just let me know. Thanks again!
Linked Issue
Closes #4264
Description
Toast overlap styling from Zag relies on the use of an
--indexCSS variable, which is created by Zag when the toast is supplied with anindexparameter. This parameter was left out of Skeleton's implementation of the Zag toast.This PR adds an optional
indexparameter to a Toast in order to maintain backwards compatibility within the major version. Docs were updated and the Playground was also updated to allow for dynamically changing the toast settings for testing.While this parameter is optional, I added it to all the docs since it doesn't hurt to be explicit.
AI Disclosure
Use of LLM technology is allowed. We ask for your voluntary disclosure to help inform future Skeleton contribution guidelines.
Checklist
Please read and apply all contribution requirements.
docs/,feature/,task/,bugfix/mainbranchpnpm checkin the root of the monorepopnpm formatin the root of the monorepopnpm lintin the root of the monorepopnpm testin the root of the monorepo/packageprojects, please supply a ChangesetChangesets
View our documentation to learn more about Changesets. To create a Changeset:
pnpm changesetand follow the prompts