[ENH] Generate synthetic stallion data for testing.#1999
[ENH] Generate synthetic stallion data for testing.#1999RihaanBH-1810 wants to merge 14 commits intosktime:mainfrom
Conversation
…ataset for the tests [wip]
There was a problem hiding this comment.
Welcome to pytorch-forecasting @RihaanBH-1810!
Thanks for the PR, this is good!
Although, there are some genuine errors/failures, can you please have a look at them? Please let us know if you need any help!
Hello, sorry I got caught up with another project that I was part of, now that it's over I'll get this done asap. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1999 +/- ##
=======================================
Coverage ? 86.53%
=======================================
Files ? 165
Lines ? 9764
Branches ? 0
=======================================
Hits ? 8449
Misses ? 1315
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@phoeenniixx I have fixed all the errors/failures can you please take a look at it. |
This PR solves #1840 by replacing the get_stallion_data which downloads the dataset with a function which generates a similar dataset for testing.
Reference Issues/PRs
#1840
What does this implement/fix? Explain your changes.
Replace get_stallion_data usage in tests with get_stallion_dummy_data to avoid repeated network downloads and support offline CI.
What should a reviewer concentrate their feedback on?
Is this the right approach for generating synthetic data for tests ?
Did you add any tests for the change?
No
Any other comments?
PR checklist
pre-commit install.To run hooks independent of commit, execute
pre-commit run --all-files