Skip to content

[ENH] Generate synthetic stallion data for testing.#1999

Open
RihaanBH-1810 wants to merge 14 commits intosktime:mainfrom
RihaanBH-1810:stallion-data-gen
Open

[ENH] Generate synthetic stallion data for testing.#1999
RihaanBH-1810 wants to merge 14 commits intosktime:mainfrom
RihaanBH-1810:stallion-data-gen

Conversation

@RihaanBH-1810
Copy link

This PR solves #1840 by replacing the get_stallion_data which downloads the dataset with a function which generates a similar dataset for testing.

Reference Issues/PRs

#1840

What does this implement/fix? Explain your changes.

Replace get_stallion_data usage in tests with get_stallion_dummy_data to avoid repeated network downloads and support offline CI.

What should a reviewer concentrate their feedback on?

Is this the right approach for generating synthetic data for tests ?

Did you add any tests for the change?

No

Any other comments?

PR checklist

  • The PR title starts with either [ENH], [MNT], [DOC], or [BUG]. [BUG] - bugfix, [MNT] - CI, test framework, [ENH] - adding or improving code, [DOC] - writing or improving documentation or docstrings.
  • Added/modified tests
  • Used pre-commit hooks when committing to ensure that code is compliant with hooks. Install hooks with pre-commit install.
    To run hooks independent of commit, execute pre-commit run --all-files

Copy link
Member

@phoeenniixx phoeenniixx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to pytorch-forecasting @RihaanBH-1810!
Thanks for the PR, this is good!
Although, there are some genuine errors/failures, can you please have a look at them? Please let us know if you need any help!

@RihaanBH-1810
Copy link
Author

Welcome to pytorch-forecasting @RihaanBH-1810! Thanks for the PR, this is good! Although, there are some genuine errors/failures, can you please have a look at them? Please let us know if you need any help!

Hello, sorry I got caught up with another project that I was part of, now that it's over I'll get this done asap.

@RihaanBH-1810 RihaanBH-1810 marked this pull request as draft January 27, 2026 16:17
@codecov
Copy link

codecov bot commented Feb 1, 2026

Codecov Report

❌ Patch coverage is 91.66667% with 4 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@dee16ad). Learn more about missing BASE report.

Files with missing lines Patch % Lines
pytorch_forecasting/data/encoders.py 71.42% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1999   +/-   ##
=======================================
  Coverage        ?   86.53%           
=======================================
  Files           ?      165           
  Lines           ?     9764           
  Branches        ?        0           
=======================================
  Hits            ?     8449           
  Misses          ?     1315           
  Partials        ?        0           
Flag Coverage Δ
cpu 86.53% <91.66%> (?)
pytest 86.53% <91.66%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RihaanBH-1810 RihaanBH-1810 marked this pull request as ready for review February 2, 2026 07:00
@RihaanBH-1810
Copy link
Author

RihaanBH-1810 commented Feb 2, 2026

@phoeenniixx I have fixed all the errors/failures can you please take a look at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants