Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| with suppress(AttributeError): | ||
| return base_object._sk_visual_block_() | ||
|
|
||
| if isinstance(base_object, str): |
Check warning
Code scanning / CodeQL
Unreachable code
| super().__init__(indent, width, depth, stream, compact=compact) | ||
| self._indent_at_name = indent_at_name | ||
| if self._indent_at_name: | ||
| self._indent_per_level = 1 # ignore indent param |
Check warning
Code scanning / CodeQL
Overwriting attribute in super-class or sub-class
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #156 +/- ##
==========================================
+ Coverage 82.68% 82.92% +0.24%
==========================================
Files 32 39 +7
Lines 2327 2799 +472
==========================================
+ Hits 1924 2321 +397
- Misses 403 478 +75
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17.
This implements
sklearnpretty printing directly inskbasewith some minor tweaks.Based on #150 by @RNKuhns, but removes the strong coupling to the new global config interface, as well as the global config interface that imo has nothing to do (or should have nothing to do) with that PR.
I think the global config interface still needs some work, and according to my comments in #150, it should be entirely uncoupled, or more precisely, coupled only via
get_config.(the alternative would be coupling it to every place where a config - local or global - is used, which is bad design)