Replace log.Fatal with graceful error handling in dmsghttp#333
Merged
0pcom merged 1 commit intoskycoin:developfrom Feb 4, 2026
Merged
Replace log.Fatal with graceful error handling in dmsghttp#3330pcom merged 1 commit intoskycoin:developfrom
0pcom merged 1 commit intoskycoin:developfrom
Conversation
0pcom
force-pushed
the
fix-getservers-fatal
branch
from
0bd1b26 to
21d7eb7
Compare
GetServers: replace log.Fatal with log.Error + retry loop on dmsg-discovery errors and fix broken recursive call. ListenAndServe: replace log.Fatal with returned error on dmsg listen failure. Update dependencies.
0pcom
force-pushed
the
fix-getservers-fatal
branch
from
21d7eb7 to
9ae6edb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GetServers: replace log.Fatal with log.Error + retry loop on dmsg-discovery errors and fix broken recursive call. ListenAndServe: replace log.Fatal with returned error on dmsg listen failure. Update dependencies.