Add bip32 support #58
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Midren
suggested changes
Jun 9, 2020
|
|
||
| HDNode* node = fsm_getDerivedNode(SECP256K1_NAME); | ||
| HDNode addressNode; | ||
| size_t size_address = 36; |
Contributor
There was a problem hiding this comment.
I think you need to add this constant to bitcoin_constants.h
Collaborator
Author
There was a problem hiding this comment.
Which one? SECP256K1_NAME constant is defined in secp256k1.h. The only option to do is to create a new constant in bitcoin_constants.h, such as:
#define BITCOIN_CURVE SECP256K1_NAME
Is it a big need to do that?
| ; | ||
|
|
||
| if (*b58sz <= zcount + size - j) { | ||
| if (*b58sz < zcount + size - j) { |
Contributor
There was a problem hiding this comment.
Are you sure, that it should be in that way ? It is part of original trezor code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Changes:
Does this change need to mentioned in CHANGELOG.md?
yes
Requires testing
no
Comments about testing , should you have some