Skip to content

Comments

fix: better package-info support#2369

Merged
skylot merged 2 commits intoskylot:masterfrom
nitram84:package_info_interface
Dec 18, 2024
Merged

fix: better package-info support#2369
skylot merged 2 commits intoskylot:masterfrom
nitram84:package_info_interface

Conversation

@nitram84
Copy link
Contributor

When I filed #1967 I had only one sample app. With https://apkpure.com/who-becomes-rich/de.sellfisch.android.wwr/download/1.15.1 I found another app with package-infos e.g. javax.annotation.package-info. This time a package-info is just an interface, nothing else. I removed some checks to support this case too.

@skylot
Copy link
Owner

skylot commented Dec 14, 2024

I think just checking for name package-info is enough. Access flags or even class type is not specified in java docs, so we can't rely on them (package info only mentioned in JLS here)
As a guard from protectors, we can also check that there are no fields and methods in that 'class'.

@skylot skylot merged commit ff95b9e into skylot:master Dec 18, 2024
4 checks passed
@skylot
Copy link
Owner

skylot commented Dec 18, 2024

@nitram84 thanks 👍

@nitram84 nitram84 deleted the package_info_interface branch May 5, 2025 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants