Skip to content

Comments

slack-19.0: use slackhq/vitess-addons@v0.19.7#575

Merged
timvaillancourt merged 16 commits intoslack-19.0from
addons-v0.19.5.slack-19.0
Jan 10, 2025
Merged

slack-19.0: use slackhq/vitess-addons@v0.19.7#575
timvaillancourt merged 16 commits intoslack-19.0from
addons-v0.19.5.slack-19.0

Conversation

@timvaillancourt
Copy link

@timvaillancourt timvaillancourt commented Dec 17, 2024

Description

This PR updates slackhq/vitess-addons to the v0.19.7 tag

Also the source-name for vtops problems was simplified to be vtorc-POOL-ENV vs. the longer/redundant vtorc-bedrock-POOL-ENV and a conditional to pass tablet alias to vtops-vtorc was added

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
@timvaillancourt timvaillancourt requested a review from a team as a code owner December 17, 2024 15:49
@github-actions github-actions bot added this to the v19.0.7 milestone Dec 17, 2024
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
ejortegau
ejortegau previously approved these changes Dec 18, 2024
@timvaillancourt timvaillancourt requested review from a team and ejortegau December 18, 2024 16:45
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
@timvaillancourt timvaillancourt changed the title slack-19.0: use slackhq/vitess-addons@v0.19.5 slack-19.0: use slackhq/vitess-addons@v0.19.6 Dec 18, 2024
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
tanjinx
tanjinx previously approved these changes Jan 9, 2025
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
tanjinx
tanjinx previously approved these changes Jan 9, 2025
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
@timvaillancourt timvaillancourt changed the title slack-19.0: use slackhq/vitess-addons@v0.19.6 slack-19.0: use slackhq/vitess-addons@v0.19.7 Jan 10, 2025
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
@timvaillancourt
Copy link
Author

Updated to v0.19.7 to fix this e2e test failure: https://slack-github.com/slack/vtops/pull/1589

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
@timvaillancourt timvaillancourt merged commit bb6271b into slack-19.0 Jan 10, 2025
163 of 165 checks passed
@timvaillancourt timvaillancourt deleted the addons-v0.19.5.slack-19.0 branch January 10, 2025 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants