VStream API [Backport]: Allow Keyspace-Level Heartbeats to be Streamed (#16593)#586
Closed
makinje16 wants to merge 10 commits intoslack-19.0from
Closed
VStream API [Backport]: Allow Keyspace-Level Heartbeats to be Streamed (#16593)#586makinje16 wants to merge 10 commits intoslack-19.0from
makinje16 wants to merge 10 commits intoslack-19.0from
Conversation
…#16593) Signed-off-by: Rohit Nayak <rohit@planetscale.com>
|
Thanks for the contribution! Before we can merge this, we need @rohit-nayak-ps to sign the Salesforce Inc. Contributor License Agreement. |
Signed-off-by: Malcolm Akinje <makinje@slack-corp.com>
Signed-off-by: Malcolm Akinje <makinje@slack-corp.com>
tanjinx
reviewed
Mar 5, 2025
| return dbc.conn.SupportsCapability(capability) | ||
| } | ||
|
|
||
| // ---------------------------------------------- |
tanjinx
reviewed
Mar 5, 2025
| func (vc *VitessCluster) AddTablet(t testing.TB, cell *Cell, keyspace *Keyspace, shard *Shard, tabletType string, tabletID int) (*Tablet, *exec.Cmd, error) { | ||
| tablet := &Tablet{} | ||
|
|
||
| options := []string{ |
Signed-off-by: Malcolm Akinje <makinje@slack-corp.com>
|
dup of #620 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a backport of vitessio#16593 needed by CDC to continue productionizing vstreams and related operations. Specifically, this introduces binlog watermarking which allows us to timestamp streams from Vitess and fulfill the requirements of being a online streaming database.
Related Issue(s)
Checklist
Deployment Notes