WIP: Stable client indexes for target selection#588
Closed
henryr wants to merge 2 commits intovtgateproxy-15from
Closed
WIP: Stable client indexes for target selection#588henryr wants to merge 2 commits intovtgateproxy-15from
henryr wants to merge 2 commits intovtgateproxy-15from
Conversation
demmer
reviewed
Jan 21, 2025
go/vt/vtgateproxy/discovery.go
Outdated
There was a problem hiding this comment.
Presumably for this approach we'd want to not do the random shuffleSort and instead make sure that the targets list is in a stable order?
Signed-off-by: Henry Robinson <hrobinson@slack-corp.com>
Signed-off-by: Henry Robinson <hrobinson@slack-corp.com>
henryr
force-pushed
the
hnr-stable-client-indexes
branch
from
35e4285 to
24ec168
Compare
|
This PR is being marked as stale because it has been open for 30 days with no activity. To rectify, you may do any of the following:
If no action is taken within 7 days, this PR will be closed. |
|
This PR was closed because it has been stale for 7 days with no activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.