Increase health check channel buffer (#17821)#624
Merged
tanjinx merged 2 commits intoslack-15.0from Mar 17, 2025
Merged
Conversation
|
Thanks for the contribution! Before we can merge this, we need @GuptaManan100 to sign the Salesforce Inc. Contributor License Agreement. |
|
@makinje16 can we also make a backport to |
Signed-off-by: Malcolm Akinje <makinje@slack-corp.com>
Signed-off-by: Malcolm Akinje <makinje@slack-corp.com>
677d41f to
49ba03c
Compare
tanjinx
approved these changes
Mar 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR backports #17821 as it solves an issue in which vtgate buffering would time out after receiving a healthcheck from a new primary.
Related Issue(s)
issue
Checklist
Deployment Notes