Skip to content

Comments

Increase health check channel buffer (#17821)#624

Merged
tanjinx merged 2 commits intoslack-15.0from
slack-15.0-vtgate-channel-buffering
Mar 17, 2025
Merged

Increase health check channel buffer (#17821)#624
tanjinx merged 2 commits intoslack-15.0from
slack-15.0-vtgate-channel-buffering

Conversation

@makinje16
Copy link

Description

This PR backports #17821 as it solves an issue in which vtgate buffering would time out after receiving a healthcheck from a new primary.

Related Issue(s)

issue

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

@makinje16 makinje16 requested review from sbaker617 and tanjinx March 12, 2025 19:02
@makinje16 makinje16 requested a review from a team as a code owner March 12, 2025 19:02
@salesforce-cla
Copy link

Thanks for the contribution! Before we can merge this, we need @GuptaManan100 to sign the Salesforce Inc. Contributor License Agreement.

@github-actions github-actions bot added this to the v15.0.5 milestone Mar 12, 2025
@timvaillancourt
Copy link

@makinje16 can we also make a backport to slack-21.0? There should be no conflicts 🤞 🙇

makinje16 and others added 2 commits March 14, 2025 10:25
Signed-off-by: Malcolm Akinje <makinje@slack-corp.com>
Signed-off-by: Malcolm Akinje <makinje@slack-corp.com>
@makinje16 makinje16 force-pushed the slack-15.0-vtgate-channel-buffering branch from 677d41f to 49ba03c Compare March 14, 2025 15:26
@tanjinx tanjinx merged commit 992b621 into slack-15.0 Mar 17, 2025
192 of 194 checks passed
@tanjinx tanjinx deleted the slack-15.0-vtgate-channel-buffering branch March 17, 2025 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants