Closed
Conversation
…vitessio#18225) Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr>
…er (vitessio#18216) (vitessio#18220) Signed-off-by: Harshit Gangal <harshit@planetscale.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com> Co-authored-by: Harshit Gangal <harshit@planetscale.com>
…ic aggregation (vitessio#18073) (vitessio#18231) Signed-off-by: Arthur Schreiber <arthurschreiber@github.com> Signed-off-by: Mohamed Hamza <mhamza15@github.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com> Co-authored-by: Mohamed Hamza <mhamza15@github.com>
vitessio#18242) (vitessio#18250) Signed-off-by: Harshit Gangal <harshit@planetscale.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
…tessio#18237) (vitessio#18245) Signed-off-by: Andres Taylor <andres@planetscale.com> Co-authored-by: Andrés Taylor <andres@planetscale.com>
…8254) (vitessio#18258) Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
…#11379 (vitessio#18260) (vitessio#18263) Signed-off-by: Arthur Schreiber <arthurschreiber@github.com> Co-authored-by: Andrés Taylor <andres@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com> Co-authored-by: Harshit Gangal <harshit@planetscale.com>
…statements (vitessio#18279) (vitessio#18293) Signed-off-by: Manan Gupta <manan@planetscale.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
…tessio#18290) Signed-off-by: Manan Gupta <manan@planetscale.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Signed-off-by: GitHub <noreply@github.com> Signed-off-by: Andres Taylor <andres@planetscale.com> Co-authored-by: frouioui <frouioui@users.noreply.github.com> Co-authored-by: Andres Taylor <andres@planetscale.com>
…ming tables and log it (vitessio#18313) (vitessio#18316) Signed-off-by: Rohit Nayak <rohit@planetscale.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
…vitessio#18345) Signed-off-by: Harshit Gangal <harshit@planetscale.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com> Co-authored-by: Harshit Gangal <harshit@planetscale.com>
…vitessio#18361) (vitessio#18363) Signed-off-by: Andres Taylor <andres@planetscale.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com> Co-authored-by: Andres Taylor <andres@planetscale.com>
…tor. (vitessio#18359) (vitessio#18368) Signed-off-by: Manan Gupta <manan@planetscale.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Signed-off-by: GitHub <noreply@github.com> Signed-off-by: Manan Gupta <manan@planetscale.com> Co-authored-by: frouioui <frouioui@users.noreply.github.com> Co-authored-by: Manan Gupta <manan@planetscale.com>
…tore=true (vitessio#18310) (vitessio#18356) Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
…Migrate test. (vitessio#18300) (vitessio#18334) Signed-off-by: Rohit Nayak <rohit@planetscale.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
…18223) (vitessio#18322) Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
…vitessio#18380) Signed-off-by: Manan Gupta <manan@planetscale.com>
…ssio#18390) (vitessio#18398) Signed-off-by: siddharth16396 <siddharth16396@gmail.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
…itessio#18414) (vitessio#18420) Signed-off-by: siddharth16396 <siddharth16396@gmail.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
…failure (vitessio#18428) (vitessio#18437) Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com> Co-authored-by: Noble Mittal <62551163+beingnoble03@users.noreply.github.com>
…SQL stalls (vitessio#17883) (vitessio#18454) Signed-off-by: Arthur Schreiber <arthurschreiber@github.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
…em passing (vitessio#18407) (vitessio#18410) Signed-off-by: Matt Lord <mattalord@gmail.com> Signed-off-by: Harshit Gangal <harshit@planetscale.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com> Co-authored-by: Harshit Gangal <harshit@planetscale.com>
…uenceTables request (vitessio#18415) (vitessio#18445) Signed-off-by: Noble Mittal <noblemittal@outlook.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com> Co-authored-by: Noble Mittal <noblemittal@outlook.com>
vitessio#18465) Signed-off-by: Andres Taylor <andres@planetscale.com> Co-authored-by: Andrés Taylor <andres@planetscale.com>
…ecord (vitessio#18478) (vitessio#18483) Signed-off-by: Rohit Nayak <rohit@planetscale.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Signed-off-by: Arthur Schreiber <arthur@planetscale.com> Co-authored-by: Arthur Schreiber <arthurschreiber@github.com>
Signed-off-by: Arthur Schreiber <arthur@planetscale.com> Co-authored-by: Arthur Schreiber <arthurschreiber@github.com>
…inary for lastpk (vitessio#18852) (vitessio#18858) Signed-off-by: Nick Van Wiggeren <nick@planetscale.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
…when we cannot (vitessio#18848) (vitessio#18861) Signed-off-by: Matt Lord <mattalord@gmail.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
…#18716) (vitessio#18872) Signed-off-by: ghostframe <marcosandresdiaz@gmail.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Signed-off-by: Matt Lord <mattalord@gmail.com>
Signed-off-by: Matt Lord <mattalord@gmail.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
* empty commit to test CI Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * update skip logic Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * update skip logic Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * add private repo token to non-template files Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * add private repo token to non-template files Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * remove ci we dont need Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * remove more ci we dont need Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * update un-templated runs-on: Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * remove even more ci we dont need Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * update un-templated runs-on:, part 2 Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * use go@1.22 for old release Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> --------- Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
* [release-22.0] Bump to `v22.0.1-SNAPSHOT` after the `v22.0.0` release (vitessio#18225) Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr> * [release-22.0] fix: Preserve multi-column TupleExpr in tuple simplifier (vitessio#18216) (vitessio#18220) Signed-off-by: Harshit Gangal <harshit@planetscale.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com> Co-authored-by: Harshit Gangal <harshit@planetscale.com> * [release-22.0] Properly handle grpc dial errors in the throttler metric aggregation (vitessio#18073) (vitessio#18231) Signed-off-by: Arthur Schreiber <arthurschreiber@github.com> Signed-off-by: Mohamed Hamza <mhamza15@github.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com> Co-authored-by: Mohamed Hamza <mhamza15@github.com> * [release-22.0] test: TestQueryTimeoutWithShardTargeting fix flaky test (vitessio#18242) (vitessio#18250) Signed-off-by: Harshit Gangal <harshit@planetscale.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com> * [release-22.0] make sure to give MEMBER OF the correct precedence (vitessio#18237) (vitessio#18245) Signed-off-by: Andres Taylor <andres@planetscale.com> Co-authored-by: Andrés Taylor <andres@planetscale.com> * [release-22.0] Fix evalengine crashes on unexpected types (vitessio#18254) (vitessio#18258) Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com> * [release-22.0] Fix subquery merging regression introduced in vitessio#11379 (vitessio#18260) (vitessio#18263) Signed-off-by: Arthur Schreiber <arthurschreiber@github.com> Co-authored-by: Andrés Taylor <andres@planetscale.com> * [release-22.0] json array insert test (vitessio#18284) (vitessio#18286) Signed-off-by: Harshit Gangal <harshit@planetscale.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com> Co-authored-by: Harshit Gangal <harshit@planetscale.com> * [release-22.0] Fix `SET` and `START TRANSACTION` in create procedure statements (vitessio#18279) (vitessio#18293) Signed-off-by: Manan Gupta <manan@planetscale.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com> * [release-22.0] Fix deadlock in semi-sync monitor (vitessio#18276) (vitessio#18290) Signed-off-by: Manan Gupta <manan@planetscale.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com> * [release-22.0] Upgrade the Golang version to `go1.24.3` (vitessio#18239) Signed-off-by: GitHub <noreply@github.com> Signed-off-by: Andres Taylor <andres@planetscale.com> Co-authored-by: frouioui <frouioui@users.noreply.github.com> Co-authored-by: Andres Taylor <andres@planetscale.com> * [release-22.0] Atomic Copy: Handle error that was ignored while streaming tables and log it (vitessio#18313) (vitessio#18316) Signed-off-by: Rohit Nayak <rohit@planetscale.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com> * [release-22.0] fix: handle dml query for None opcode (vitessio#18326) (vitessio#18345) Signed-off-by: Harshit Gangal <harshit@planetscale.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com> Co-authored-by: Harshit Gangal <harshit@planetscale.com> * [release-22.0] fix: keep LIMIT/OFFSET even when merging UNION queries (vitessio#18361) (vitessio#18363) Signed-off-by: Andres Taylor <andres@planetscale.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com> Co-authored-by: Andres Taylor <andres@planetscale.com> * [release-22.0] Fix: Deadlock in `Close` and `write` in semi-sync monitor. (vitessio#18359) (vitessio#18368) Signed-off-by: Manan Gupta <manan@planetscale.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com> * [release-22.0] Upgrade the Golang version to `go1.24.4` (vitessio#18329) Signed-off-by: GitHub <noreply@github.com> Signed-off-by: Manan Gupta <manan@planetscale.com> Co-authored-by: frouioui <frouioui@users.noreply.github.com> Co-authored-by: Manan Gupta <manan@planetscale.com> * [release-22.0] fix version issue when using --mysql-shell-speedup-restore=true (vitessio#18310) (vitessio#18356) Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com> * [release-22.0] Split workflow with flaky vdiff2 e2e test. Skip flaky Migrate test. (vitessio#18300) (vitessio#18334) Signed-off-by: Rohit Nayak <rohit@planetscale.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com> * [release-22.0] Throttler: keep watching topo even on error (vitessio#18223) (vitessio#18322) Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com> * [release-22.0] Code Freeze for `v22.0.1` (vitessio#18374) Signed-off-by: Manan Gupta <manan@planetscale.com> * [release-22.0] Release of `v22.0.1` (vitessio#18375) Signed-off-by: Manan Gupta <manan@planetscale.com> * add private repo config to new CI file Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * `make generate_ci_workflows` Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> --------- Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Harshit Gangal <harshit@planetscale.com> Signed-off-by: Arthur Schreiber <arthurschreiber@github.com> Signed-off-by: Mohamed Hamza <mhamza15@github.com> Signed-off-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Manan Gupta <manan@planetscale.com> Signed-off-by: GitHub <noreply@github.com> Signed-off-by: Rohit Nayak <rohit@planetscale.com> Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> Co-authored-by: vitess-bot <139342327+vitess-bot@users.noreply.github.com> Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com> Co-authored-by: Harshit Gangal <harshit@planetscale.com> Co-authored-by: Mohamed Hamza <mhamza15@github.com> Co-authored-by: Andrés Taylor <andres@planetscale.com> Co-authored-by: frouioui <frouioui@users.noreply.github.com> Co-authored-by: Manan Gupta <manan@planetscale.com> Co-authored-by: Manan Gupta <guptamanan100@gmail.com>
* support mysql protocol connection attributes (vitessio#18548) Signed-off-by: Michael Demmer <mdemmer@slack-corp.com> * vtgateconn minor enhancements (vitessio#18551) Signed-off-by: Michael Demmer <mdemmer@slack-corp.com> * add DialCustom for overridden runtime behavior Signed-off-by: Michael Demmer <mdemmer@slack-corp.com> --------- Signed-off-by: Michael Demmer <mdemmer@slack-corp.com>
…ERS` (#709) * `slack-22.0`: setup `slack_cross_cell` durability policy + `CODEOWNERS` Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * fix path Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * fix package Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * add `GOPRIVATE` to docker Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * fix private repo in docker builds Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * update docker files Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com> * update docker test Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com> * fix vitess-addons Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com> * undo pre release version change Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com> * fix vitess-addon Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com> * update vitess-addon Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com> * update go version for v19 build Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com> * update vitess-addons Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com> * update vitess-addons Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com> * fix vitess-addon Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com> * Revert "fix vitess-addon" This reverts commit 3fc0d3f84bd04a59f9f9e4d7aa26f9ca3dc8b268. * update test Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com> * update test Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com> * fix help message Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com> * Fix regression in v22 around new flag setup (vitessio#18507) Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com> * fix help message Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com> * fix help message Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com> * [release-22.0] CI: Fix `VDiff2` flaky e2e test (vitessio#18494) (vitessio#18526) Signed-off-by: Noble Mittal <noblemittal@outlook.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com> * skip few ci tests Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com> * disable one query in v19 downgrade testing Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com> * update test Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com> * update test Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com> --------- Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com> Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Signed-off-by: Noble Mittal <noblemittal@outlook.com> Co-authored-by: Tim Vaillancourt <tim@timvaillancourt.com> Co-authored-by: Dirkjan Bussink <d.bussink@gmail.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
…724) * Update mysql-apt-config to version 0.8.35-1 across all CI workflows Updated mysql-apt-config package from version 0.8.33-1 to 0.8.35-1 in all template files and individual workflow files to use the latest available version. Changes: - Updated all template files (cluster_endtoend_test.tpl, cluster_endtoend_test_mysql57.tpl, cluster_vitess_tester.tpl, unit_test.tpl) - Updated individual workflow files (upgrade_downgrade_test_*, e2e_race.yml) - Regenerated all workflow files from updated templates All workflow files now consistently use mysql-apt-config_0.8.35-1_all.deb for MySQL repository configuration. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com> Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com> * Remove MySQL uninstall steps from CI workflows Removed MySQL uninstall sections that included systemctl stop apparmor, apt-get remove, autoremove, autoclean, deluser mysql, and rm -rf commands. These steps were unnecessary and could cause issues in CI environments. Changes: - Removed uninstall sections from template files (unit_test.tpl, cluster_endtoend_test_mysql57.tpl) - Removed uninstall sections from workflow files (upgrade_downgrade_test_*, unit_test_*) - Regenerated workflow files from updated templates The workflows now proceed directly to MySQL repository setup and installation without attempting to uninstall previous MySQL installations. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com> Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com> * revert some changes Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com> * re-gen the tests Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com> * fix pkg conflicts Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com> --------- Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com> Co-authored-by: Claude <svc-devxp-claude@slack-corp.com>
* VStream: Add flag to support copying only specific tables (vitessio#18184) Signed-off-by: Thomas Thornton <tthornton@salesforce.com> * Add a flag to vstream to exclude keyspace from table name (vitessio#18274) Signed-off-by: Thomas Thornton <tthornton@salesforce.com> * Fix flakey vstream metrics test (vitessio#18287) Signed-off-by: Thomas Thornton <tthornton@salesforce.com> * Add support for sending grpc server backend metrics via ORCA (vitessio#18282) Signed-off-by: Thomas Thornton <tthornton@salesforce.com> * VStream: Try new tablet on purged binlog error (vitessio#18710) Signed-off-by: twthorn <thomaswilliamthornton@gmail.com> * Run go mod tidy Signed-off-by: Thomas Thornton <tthornton@salesforce.com> * Run go fmt Signed-off-by: Thomas Thornton <tthornton@salesforce.com> * Regenerate proto files Signed-off-by: Thomas Thornton <tthornton@salesforce.com> * Fix sorting of --grpc-enable-orca-metrics flag Signed-off-by: Thomas Thornton <tthornton@salesforce.com> * Fix ordering of -grpc-enable-orca-metrics in vtcombo.txt Signed-off-by: Thomas Thornton <tthornton@salesforce.com> --------- Signed-off-by: Thomas Thornton <tthornton@salesforce.com> Signed-off-by: twthorn <thomaswilliamthornton@gmail.com> Co-authored-by: Noble Mittal <62551163+beingnoble03@users.noreply.github.com> Co-authored-by: Tanjin Xu <109303790+tanjinx@users.noreply.github.com>
…#726) * fix: consolidator waiter cap fallback to independent execution When the consolidator waiter cap is reached, queries should fall back to independent execution instead of returning empty results. Before this fix: - Queries exceeding waiter cap would skip waiting for consolidation - They would immediately try to access q.Result() before completion - This resulted in empty/incomplete results being returned After this fix: - Queries exceeding waiter cap fall back to regular execution path - All queries return correct results regardless of consolidation status - Waiter cap configuration still controls resource usage as intended Changes: - Modified execSelect() in query_executor.go to implement fallback logic - Enhanced FakePendingResult to properly simulate waiter count behavior - Added comprehensive test TestQueryExecutorConsolidatorWaiterCapFallback * implement consolidator-query-waiter-cap-method * fix help message * fix redundant code * fix test * feat: add consolidator-query-waiter-cap-method config parameter Add --consolidator-query-waiter-cap-method flag to control behavior when consolidator waiter cap is exceeded. Options: - 'fallthrough' (default): Fall back to independent query execution - 'reject': Return RESOURCE_EXHAUSTED error This provides operators fine-grained control over consolidator memory management while maintaining backward compatibility. Changes: - Add ConsolidatorQueryWaiterCapMethod config field and CLI flag - Update execSelect() to handle both reject and fallthrough behaviors - Add comprehensive test coverage for both methods - Add config validation with graceful defaults - Fix waiter counter cleanup to ensure proper resource management --------- Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com> Co-authored-by: Claude <svc-devxp-claude@slack-corp.com>
…ng (vitessio#18520) (#710) Signed-off-by: Henry Cai <henry.cai@slack-corp.com> Co-authored-by: Tanjin Xu <109303790+tanjinx@users.noreply.github.com>
…) (#731) Signed-off-by: Henry Cai <henry.cai@slack-corp.com> Co-authored-by: Henry Haiying Cai <HenryCaiHaiying@users.noreply.github.com>
…ting for connection (#727) * [release-22.0] CONNPOOL: Fix race condition when waiting for connection (vitessio#18713) (vitessio#18721) Signed-off-by: Arthur Schreiber <arthurschreiber@github.com> Signed-off-by: Matt Lord <mattalord@gmail.com> Signed-off-by: Arthur Schreiber <arthur@planetscale.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com> Co-authored-by: Matt Lord <mattalord@gmail.com> Co-authored-by: Arthur Schreiber <arthur@planetscale.com> * [release-22.0] connpool: Bump the hang detection timeout to fix flakiness (vitessio#18722) (vitessio#18724) Signed-off-by: Arthur Schreiber <arthur@planetscale.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com> * Revert "[release-22.0] connpool: Bump the hang detection timeout to fix flakiness (vitessio#18722) (vitessio#18724)" This reverts commit 4dac149. * Revert "[release-22.0] CONNPOOL: Fix race condition when waiting for connection (vitessio#18713) (vitessio#18721)" This reverts commit 9ab76bf. * [release-22.0] CONNPOOL: Fix race condition when waiting for connection (vitessio#18713) (vitessio#18721) Signed-off-by: Arthur Schreiber <arthurschreiber@github.com> Signed-off-by: Matt Lord <mattalord@gmail.com> Signed-off-by: Arthur Schreiber <arthur@planetscale.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com> Co-authored-by: Matt Lord <mattalord@gmail.com> Co-authored-by: Arthur Schreiber <arthur@planetscale.com> * connpool: Don't use go internal `sema` functionality (vitessio#18719) Signed-off-by: Arthur Schreiber <arthur@planetscale.com> * [release-22.0] connpool: Bump the hang detection timeout to fix flakiness (vitessio#18722) (vitessio#18724) Signed-off-by: Arthur Schreiber <arthur@planetscale.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com> --------- Signed-off-by: Arthur Schreiber <arthurschreiber@github.com> Signed-off-by: Matt Lord <mattalord@gmail.com> Signed-off-by: Arthur Schreiber <arthur@planetscale.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com> Co-authored-by: Matt Lord <mattalord@gmail.com> Co-authored-by: Arthur Schreiber <arthur@planetscale.com> Co-authored-by: Arthur Schreiber <arthurschreiber@github.com>
#729) Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> Co-authored-by: Tim Vaillancourt <tim@timvaillancourt.com>
…d candidate selection (vitessio#18531) (#736) Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> Co-authored-by: Tim Vaillancourt <tim@timvaillancourt.com>
… (#740) Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com> Co-authored-by: Tim Vaillancourt <tim@timvaillancourt.com>
Signed-off-by: Renan Rangel <rrangel@slack-corp.com>
…ation (#741) * backport tablet type lookup to v22 Signed-off-by: Stephen Baker <s.baker@slack-corp.com> * more txt adjustments --------- Signed-off-by: Stephen Baker <s.baker@slack-corp.com> Co-authored-by: Tanjin Xu <109303790+tanjinx@users.noreply.github.com>
…itessio#18234) (#739) Signed-off-by: Banty Kumar <bantyp92@gmail.com> Signed-off-by: Manan Gupta <manan@planetscale.com> Co-authored-by: Banty Kumar <bantyp92@gmail.com> Co-authored-by: Manan Gupta <manan@planetscale.com>
|
Thanks for the contribution! Before we can merge this, we need @vitess-bot @GuptaManan100 to sign the Salesforce Inc. Contributor License Agreement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue(s)
Checklist
Deployment Notes
AI Disclosure