Fix GC table regex for lower case compatibility#753
Merged
tanjinx merged 2 commits intoslack-19.0from Nov 22, 2025
Merged
Conversation
tanjinx
previously approved these changes
Nov 22, 2025
tanjinx
approved these changes
Nov 22, 2025
yushuqin
added a commit
that referenced
this pull request
Dec 2, 2025
* Fix GC table regex for lower case compatibility * gofmt
yushuqin
added a commit
that referenced
this pull request
Jan 27, 2026
Signed-off-by: 'Yushu Qin' <yqin@slack-corp.com>
yushuqin
added a commit
that referenced
this pull request
Jan 27, 2026
Signed-off-by: 'Yushu Qin' <yqin@slack-corp.com>
yushuqin
added a commit
that referenced
this pull request
Jan 27, 2026
Signed-off-by: 'Yushu Qin' <yqin@slack-corp.com>
tanjinx
added a commit
that referenced
this pull request
Jan 27, 2026
* Fix zero timestamp in vifl (#773) Co-authored-by: Tanjin Xu <109303790+tanjinx@users.noreply.github.com> * [`slack-19.0`]: backport: Increase GTID position column size to LONGBLOB for VReplication (vitessio#19119) (#770) This backport increases the GTID position column size from BLOB to LONGBLOB in VReplication tables to prevent data truncation for large GTID sets. Backported from vitessio#19119 Original commit: fc242ff Changes: - Update schema_version.sql to use LONGBLOB for pos column - Update vreplication.sql to use LONGBLOB for pos column - Update schema tests to reflect new column type Note: Test file changes from upstream were not included as they depend on features not present in slack-19.0 branch. Core schema changes are sufficient. * Fix GC table regex for lower case compatibility (#753) Signed-off-by: 'Yushu Qin' <yqin@slack-corp.com> --------- Signed-off-by: 'Yushu Qin' <yqin@slack-corp.com> Co-authored-by: Tanjin Xu <109303790+tanjinx@users.noreply.github.com>
sbaker617
pushed a commit
that referenced
this pull request
Feb 5, 2026
* Fix zero timestamp in vifl (#773) Co-authored-by: Tanjin Xu <109303790+tanjinx@users.noreply.github.com> * [`slack-19.0`]: backport: Increase GTID position column size to LONGBLOB for VReplication (vitessio#19119) (#770) This backport increases the GTID position column size from BLOB to LONGBLOB in VReplication tables to prevent data truncation for large GTID sets. Backported from vitessio#19119 Original commit: fc242ff Changes: - Update schema_version.sql to use LONGBLOB for pos column - Update vreplication.sql to use LONGBLOB for pos column - Update schema tests to reflect new column type Note: Test file changes from upstream were not included as they depend on features not present in slack-19.0 branch. Core schema changes are sufficient. * Fix GC table regex for lower case compatibility (#753) Signed-off-by: 'Yushu Qin' <yqin@slack-corp.com> --------- Signed-off-by: 'Yushu Qin' <yqin@slack-corp.com> Co-authored-by: Tanjin Xu <109303790+tanjinx@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem: When MySQL is configured with lower_case_table_names=1, all table names are stored in lowercase. Vitess generates GC table names like vt_HOLD, but MySQL stores them as vt_hold. The old regex only matched uppercase state names, causing TableGC to fail to recognize.
Solution: The fix makes the GC table recognition case-insensitive while maintaining backward compatibility with existing uppercase table names.
Test: Test on poo1 staging tablets, all the old vt_hold* and vt_purge* can be cleaned up successfully.
Related Issue(s)
Checklist
Deployment Notes
AI Disclosure