Backports to support compiling v19 with go 1.24 #754
Merged
tanjinx merged 3 commits intoslack-19.0from Jan 23, 2026
Merged
Conversation
…larity (vitessio#15438) Signed-off-by: Aoang <aoang@x2oe.com> Signed-off-by: Eduardo Ortega <5791035+ejortegau@users.noreply.github.com>
Signed-off-by: Vicent Marti <vmg@strn.cat>
|
Thanks for the contribution! Before we can merge this, we need @Aoang @vmg to sign the Salesforce Inc. Contributor License Agreement. |
|
This PR is being marked as stale because it has been open for 30 days with no activity. To rectify, you may do any of the following:
If no action is taken within 7 days, this PR will be closed. |
|
This PR was closed because it has been stale for 7 days with no activity. |
|
Thanks for the contribution! Before we can merge this, we need @vmg to sign the Salesforce Inc. Contributor License Agreement. |
tanjinx
approved these changes
Jan 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This backports vitessio#15438 and vitessio#16016
so that we can compile v19 with go 1.24. The context is that we need vitess libraries in Gondola for pronto executor
service discovery, and gondola requires 1.24.