Skip to content

Comments

[slack-19.0] backport: bug: Change connection pool idle expiration logic (19004)#763

Merged
tanjinx merged 8 commits intoslack-19.0from
backport-19004
Dec 11, 2025
Merged

[slack-19.0] backport: bug: Change connection pool idle expiration logic (19004)#763
tanjinx merged 8 commits intoslack-19.0from
backport-19004

Conversation

@tanjinx
Copy link

@tanjinx tanjinx commented Dec 10, 2025

Description

backport:

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

AI Disclosure

@arthurschreiber @tanjinx
Change how we expire idle connections.
1e3adcb 
Signed-off-by: Arthur Schreiber <arthur@planetscale.com>
Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com>
@arthurschreiber @tanjinx
Add a test.
6b3d3e6 
Signed-off-by: Arthur Schreiber <arthur@planetscale.com>
@arthurschreiber @tanjinx
Loosen up test requirements.
ed617ca 
Signed-off-by: Arthur Schreiber <arthur@planetscale.com>
@arthurschreiber @tanjinx
Expire only up to 50% of the connections, and add some comments.
f3a8a0b 
Signed-off-by: Arthur Schreiber <arthur@planetscale.com>
@arthurschreiber @tanjinx
Also pre-allocate the valid connections slice.
be1c728 
Signed-off-by: Arthur Schreiber <arthur@planetscale.com>
@arthurschreiber @tanjinx
Skip slice allocations for empty stacks.
39cafa1 
Signed-off-by: Arthur Schreiber <arthur@planetscale.com>
@arthurschreiber @tanjinx
Fix benchmark setup.
a588232 
Signed-off-by: Arthur Schreiber <arthur@planetscale.com>
@tanjinx tanjinx added the bug Something isn't working label Dec 10, 2025
@tanjinx tanjinx requested a review from a team as a code owner December 10, 2025 23:43
@salesforce-cla
Copy link

salesforce-cla bot commented Dec 10, 2025

Thanks for the contribution! Before we can merge this, we need @arthurschreiber to sign the Salesforce Inc. Contributor License Agreement.

@github-actions github-actions bot added this to the v19.0.7 milestone Dec 10, 2025
@tanjinx
fix b.Loop
856324d 
Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com>
@tanjinx tanjinx merged commit 11103fa into slack-19.0 Dec 11, 2025
162 of 170 checks passed
@tanjinx tanjinx deleted the backport-19004 branch December 11, 2025 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sbaker617 sbaker617 sbaker617 approved these changes

Assignees

No one assigned

Labels

bug Something isn't working cla:missing v19 v24-backport

Projects

None yet

Milestone

v19.0.7

Development

Successfully merging this pull request may close these issues.

3 participants

@tanjinx @sbaker617 @arthurschreiber