Skip to content

Fix zero timestamp in vifl #773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tanjinx merged 2 commits into from
Jan 20, 2026
Merged

Fix zero timestamp in vifl #773

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
077802a
Fix zero timestamp in vifl
yushuqin Jan 20, 2026
19d2bd2
Merge branch 'slack-19.0' into yqin-fix-zero-timestamp
tanjinx Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions go/vt/vtctl/grpcvtctldserver/query.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,13 @@ func valueToVTTime(s string) (*vttime.Time, error) {
return nil, nil
}

// Handle MySQL's zero/NULL timestamp (0000-00-00 00:00:00)
// This is what MySQL returns for NULL datetime values when the connection
// is not configured to return SQL NULL values.
if len(s) >= 10 && s[:10] == "0000-00-00" {
return nil, nil
}

gotime, err := time.ParseInLocation(sqltypes.TimestampFormat, s, time.Local)
if err != nil {
return nil, err
Expand Down
10 changes: 10 additions & 0 deletions go/vt/vtctl/grpcvtctldserver/query_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,16 @@ func TestValueToVTTime(t *testing.T) {
value: "",
expected: nil,
},
{
name: "MySQL zero timestamp",
value: "0000-00-00 00:00:00",
expected: nil,
},
{
name: "MySQL zero timestamp with microseconds",
value: "0000-00-00 00:00:00.000000",
expected: nil,
},
{
name: "parse error",
value: "2006/01/02",
Expand Down
Loading