[`slack-22.0`] set the previous release to slack-19.0 by tanjinx · Pull Request #774 · slackhq/vitess

tanjinx · 2026-01-20T21:33:50Z

Description

Set previous build to slack-19.0 so the CI upgrade/downgrade tests will verify our upgrade path v19->v22

Related Issue(s)

Checklist

"Backport to:" labels have been added if this change should be back-ported to release branches
If this change is to be back-ported to previous releases, a justification is included in the PR description
Tests were added or are not required
Did the new or modified tests pass consistently locally and on CI?
Documentation was added or is not required

Deployment Notes

AI Disclosure

Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com>

codecov-commenter · 2026-01-23T00:34:33Z

Codecov Report

❌ Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.74%. Comparing base (b1ab347) to head (e1e3ead).
⚠️ Report is 22 commits behind head on slack-22.0.

Files with missing lines	Patch %	Lines
go/vt/schemamanager/tablet_executor.go	0.00%	10 Missing ⚠️

Additional details and impacted files

@@              Coverage Diff               @@
##           slack-22.0     #774      +/-   ##
==============================================
+ Coverage       67.53%   69.74%   +2.20%     
==============================================
  Files            1600     1605       +5     
  Lines          261782   213558   -48224     
==============================================
- Hits           176786   148937   -27849     
+ Misses          84996    64621   -20375

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Add safeguards to prevent TestFailingReplication from timing out: 1. Add 10-second timeout for redo log verification loop to prevent indefinite waiting if error_log entries don't appear 2. Check if performance_schema.error_log table exists and is accessible before querying it for redo log error codes 3. Skip verification gracefully with logging instead of failing test Also update throttler configuration to directly set throttled apps without time-based expiration checks (to be restored in v22). Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com> Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com>

Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com>

When running downgrade/upgrade tests with v19.0, ExecuteMultiFetchAsDba is not available on older tablets. Add fallback to use ExecuteFetchAsDba when the method is unimplemented. The error is wrapped as 'Unknown' containing 'Unimplemented', so we check both the error code and the error message for 'unknown method ExecuteMultiFetchAsDba'. This fixes the onlineddl_flow_test failure: unknown method ExecuteMultiFetchAsDba for service tabletmanagerservice.TabletManager Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com> Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com>

Restore the time-based expiration check for throttled apps that was removed in the previous commit. The removal was causing the throttler to return UNDEFINED status during downgrade/upgrade tests with v19.0. This reverts the throttler-related changes from commit 67d81de, while keeping the backup test redo log verification fixes. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com> Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com>

Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com>

.github/workflows/upgrade_downgrade_test_onlineddl_flow.yml

Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com>

Percona repository structure now requires the tools repository to be enabled before setting up ps80. This fixes the CI error: "Selected product uses 'ps-80 tools' repositories. But the 'tools' repository is disabled" Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com> Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com>

.github/workflows/cluster_endtoend_backup_pitr_xtrabackup.yml

* set the previous release to slack-19.0 Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com> * fix vitess-addons access Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com> * fix vitess-addons Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com> * fix vitess-addons Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com> * add back downgrade/upgrade test changes for GetThrottlerStatus grpc Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com> * fix: add redo log verification timeout and throttler changes Add safeguards to prevent TestFailingReplication from timing out: 1. Add 10-second timeout for redo log verification loop to prevent indefinite waiting if error_log entries don't appear 2. Check if performance_schema.error_log table exists and is accessible before querying it for redo log error codes 3. Skip verification gracefully with logging instead of failing test Also update throttler configuration to directly set throttled apps without time-based expiration checks (to be restored in v22). Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com> Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com> * fix throttler test Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com> * fix: add v19.0 compatibility fallback for ExecuteMultiFetchAsDba When running downgrade/upgrade tests with v19.0, ExecuteMultiFetchAsDba is not available on older tablets. Add fallback to use ExecuteFetchAsDba when the method is unimplemented. The error is wrapped as 'Unknown' containing 'Unimplemented', so we check both the error code and the error message for 'unknown method ExecuteMultiFetchAsDba'. This fixes the onlineddl_flow_test failure: unknown method ExecuteMultiFetchAsDba for service tabletmanagerservice.TabletManager Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com> Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com> * Revert throttler expiration check removal Restore the time-based expiration check for throttled apps that was removed in the previous commit. The removal was causing the throttler to return UNDEFINED status during downgrade/upgrade tests with v19.0. This reverts the throttler-related changes from commit 67d81de, while keeping the backup test redo log verification fixes. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com> Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com> * revert throttler_test change Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com> * add logging for debugging Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com> * fix nil pointer Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com> * undo the logging changes Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com> * skip onlineddl downgrade/upgrade tests Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com> * undo disabling online ddl upgrade test Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com> * disabling online ddl upgrade test Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com> * undo disabling of v23 downgrade testing Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com> * fix: enable Percona tools repository before ps80 setup Percona repository structure now requires the tools repository to be enabled before setting up ps80. This fixes the CI error: "Selected product uses 'ps-80 tools' repositories. But the 'tools' repository is disabled" Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com> Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com> --------- Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com> Co-authored-by: Claude <svc-devxp-claude@slack-corp.com>

set the previous release to slack-19.0

44aac78

Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com>

tanjinx requested a review from a team as a code owner January 20, 2026 21:33

tanjinx added this to the v22.0.2 milestone Jan 20, 2026

tanjinx added 4 commits January 20, 2026 13:53

fix vitess-addons access

b728006

Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com>

fix vitess-addons

2037cd8

Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com>

fix vitess-addons

3a64a78

Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com>

add back downgrade/upgrade test changes for GetThrottlerStatus grpc

7dac533

Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com>

tanjinx and others added 3 commits January 22, 2026 16:53

fix throttler test

5eae53a

Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com>

tanjinx force-pushed the retest-downgrade-upgrade-ci-with-19.0 branch from 70f445b to 2edf8b2 Compare January 23, 2026 01:36

tanjinx and others added 8 commits January 22, 2026 17:53

revert throttler_test change

a32914a

Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com>

add logging for debugging

0dd7bc7

Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com>

fix nil pointer

b6173ee

Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com>

undo the logging changes

601c56f

Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com>

skip onlineddl downgrade/upgrade tests

3cc55ec

Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com>

undo disabling online ddl upgrade test

d76d8e9

Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com>

disabling online ddl upgrade test

49be553

Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com>

tanjinx commented Jan 26, 2026

View reviewed changes

.github/workflows/upgrade_downgrade_test_onlineddl_flow.yml Show resolved Hide resolved

undo disabling of v23 downgrade testing

986f909

Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com>

tanjinx force-pushed the retest-downgrade-upgrade-ci-with-19.0 branch from 15fd971 to c7972e2 Compare January 26, 2026 18:28

tanjinx force-pushed the retest-downgrade-upgrade-ci-with-19.0 branch from c7972e2 to e1e3ead Compare January 26, 2026 18:31

tanjinx commented Jan 26, 2026

View reviewed changes

.github/workflows/cluster_endtoend_backup_pitr_xtrabackup.yml Show resolved Hide resolved

yushuqin approved these changes Jan 26, 2026

View reviewed changes

tanjinx merged commit d1c8c7b into slack-22.0 Jan 26, 2026
86 of 92 checks passed

tanjinx deleted the retest-downgrade-upgrade-ci-with-19.0 branch January 26, 2026 22:31

sbaker617 mentioned this pull request Feb 5, 2026

Rebase yolo-rebase-22.03 onto v22.0.3 #790

Open

10 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

[`slack-22.0`] set the previous release to slack-19.0#774

[`slack-22.0`] set the previous release to slack-19.0#774
tanjinx merged 18 commits intoslack-22.0from
retest-downgrade-upgrade-ci-with-19.0

tanjinx commented Jan 20, 2026 •

edited

Loading

Uh oh!

codecov-commenter commented Jan 23, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments

Conversation

tanjinx commented Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issue(s)

Checklist

Deployment Notes

AI Disclosure

Uh oh!

codecov-commenter commented Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

tanjinx commented Jan 20, 2026 •

edited

Loading

codecov-commenter commented Jan 23, 2026 •

edited

Loading