[slack-19.0]:[Direct PR] [release-21.0] Augment PrimaryStatus to also send Serve…#775
Merged
tanjinx merged 4 commits intoslack-19.0from Jan 22, 2026
Merged
[slack-19.0]:[Direct PR] [release-21.0] Augment PrimaryStatus to also send Serve…#775tanjinx merged 4 commits intoslack-19.0from
slack-19.0]:[Direct PR] [release-21.0] Augment PrimaryStatus to also send Serve…#775tanjinx merged 4 commits intoslack-19.0from
Conversation
|
Thanks for the contribution! Before we can merge this, we need @GuptaManan100 to sign the Salesforce Inc. Contributor License Agreement. |
…r UUID (vitessio#17032) Signed-off-by: Manan Gupta <manan@planetscale.com>
tanjinx
force-pushed
the
backport-primarystatus-rpc
branch
from
c1dcfe9 to
46de011
Compare
ejortegau
previously approved these changes
Jan 22, 2026
Disable flaky tests: - TestDownPrimaryPromotionRuleWithLag - TestDownPrimaryPromotionRuleWithLagCrossCenter Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
tanjinx
force-pushed
the
backport-primarystatus-rpc
branch
2 times, most recently
from
f1f447c to
708dc2b
Compare
Add two safeguards to prevent TestTabletInitialBackup from timing out: 1. Check if performance_schema.error_log table exists and is accessible before querying it for redo log error codes 2. Add a 10-second timeout for the verification loop to prevent indefinite waiting if the error codes never appear in the error_log The performance_schema.error_log table requires MySQL 8.0.22+ and specific configuration. Even when the table exists, it may not be configured to log the redo log disable/enable events (MY-013600, MY-013601). If the verification times out, it now logs a message and skips gracefully instead of failing the entire test. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
tanjinx
force-pushed
the
backport-primarystatus-rpc
branch
from
708dc2b to
bd987ce
Compare
Use assert.EventuallyWithT to wait for connection cleanup instead of checking connCount and connSlow immediately after client disconnect. The server's cleanup goroutine needs time to execute defer statements that update these metrics. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…r UUID (vitessio#17032)
Description
backport vitessio#17032 to support the upgrade from v19 to v22
Related Issue(s)
Checklist
Deployment Notes
AI Disclosure