[slack-22.0]: forward port: consul conn override flags (Slack)#783
Merged
tanjinx merged 3 commits intoslack-22.0from Jan 29, 2026
Merged
[slack-22.0]: forward port: consul conn override flags (Slack)#783tanjinx merged 3 commits intoslack-22.0from
slack-22.0]: forward port: consul conn override flags (Slack)#783tanjinx merged 3 commits intoslack-22.0from
Conversation
* `slack-vitess-r14.0.5`: allow conn overrides in consul topo (#111) * `slack-vitess-r14.0.5`: allow conn overrides in consul topo Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * fix e2e test Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> --------- Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Update flags tests that didn't exist in v14 Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> --------- Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com> Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com>
tanjinx
force-pushed
the
forward-port-consul-conn-flags
branch
from
8f4e83f to
9661f09
Compare
seagraveslack
previously approved these changes
Jan 29, 2026
Adds topo_consul_idle_conn_timeout, topo_consul_max_conns_per_host, and topo_consul_max_idle_conns flags to vtcombo.txt to match vtgate.txt. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com> Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## slack-22.0 #783 +/- ##
==============================================
+ Coverage 67.53% 69.73% +2.20%
==============================================
Files 1600 1605 +5
Lines 261782 213563 -48219
==============================================
- Hits 176786 148924 -27862
+ Misses 84996 64639 -20357 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sbaker617
pushed a commit
that referenced
this pull request
Feb 5, 2026
* : forward-port consul topo limits PR #111 (#297) * `slack-vitess-r14.0.5`: allow conn overrides in consul topo (#111) * `slack-vitess-r14.0.5`: allow conn overrides in consul topo Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * fix e2e test Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> --------- Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Update flags tests that didn't exist in v14 Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> --------- Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com> Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com> * fix txt Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com> * Add missing consul connection flags to vtcombo.txt Adds topo_consul_idle_conn_timeout, topo_consul_max_conns_per_host, and topo_consul_max_idle_conns flags to vtcombo.txt to match vtgate.txt. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com> Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com> --------- Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com> Co-authored-by: Tim Vaillancourt <tim@timvaillancourt.com> Co-authored-by: Claude <svc-devxp-claude@slack-corp.com>
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
forward port slack-specific consul connection config override
#111
Related Issue(s)
Checklist
Deployment Notes
AI Disclosure