[slack-22.0] V22 cdc backports round two#784
Merged
tanjinx merged 10 commits intoslack-22.0from Jan 30, 2026
Merged
Conversation
Signed-off-by: Matt Lord <mattalord@gmail.com> Signed-off-by: Thomas Thornton <thomaswilliamthornton@gmail.com>
…nd chunks to client (vitessio#18849) Signed-off-by: twthorn <thomaswilliamthornton@gmail.com> Signed-off-by: Thomas Thornton <thomaswilliamthornton@gmail.com>
…se cases (vitessio#18938) Signed-off-by: twthorn <thomaswilliamthornton@gmail.com> Signed-off-by: Thomas Thornton <thomaswilliamthornton@gmail.com> Signed-off-by: Thomas Thornton <thomaswilliamthornton@gmail.com>
Signed-off-by: Thomas Thornton <thomaswilliamthornton@gmail.com>
seagraveslack
previously approved these changes
Jan 29, 2026
Apply missing changes from PR vitessio#18791 to metrics_cgroup.go: - Replace cgroup1Manager and cgroup2Manager with single cgroupManager - Add errCgroupMetricsNotAvailable error variable - Add sync.Once for lazy initialization - Remove cgroup v1 support, only support cgroup v2 - Simplify implementation with unified cgroup manager This fixes compilation errors in metrics_cgroup_test.go.
Required by metrics_cgroup.go for cgroup v1/v2 support. Signed-off-by: Thomas Thornton <thomaswilliamthornton@gmail.com>
The v1 cgroups package is incompatible with Go 1.24.10. Use cgroups/v3 consistently throughout the file. Signed-off-by: Thomas Thornton <thomaswilliamthornton@gmail.com>
Signed-off-by: Thomas Thornton <thomaswilliamthornton@gmail.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## slack-22.0 #784 +/- ##
==============================================
+ Coverage 67.53% 69.74% +2.21%
==============================================
Files 1600 1605 +5
Lines 261782 213608 -48174
==============================================
- Hits 176786 148989 -27797
+ Misses 84996 64619 -20377 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tanjinx
approved these changes
Jan 30, 2026
tanjinx
changed the title
slack-22.0] V22 cdc backports round two
sbaker617
pushed a commit
that referenced
this pull request
Feb 5, 2026
* Improve cgroup metric management (vitessio#18791) Signed-off-by: Matt Lord <mattalord@gmail.com> Signed-off-by: Thomas Thornton <thomaswilliamthornton@gmail.com> * VStream: Prevent buffering entire transactions (OOM risk), instead send chunks to client (vitessio#18849) Signed-off-by: twthorn <thomaswilliamthornton@gmail.com> Signed-off-by: Thomas Thornton <thomaswilliamthornton@gmail.com> * Run VStream copy only when VGTID requires it, use TablesToCopy in those cases (vitessio#18938) Signed-off-by: twthorn <thomaswilliamthornton@gmail.com> Signed-off-by: Thomas Thornton <thomaswilliamthornton@gmail.com> Signed-off-by: Thomas Thornton <thomaswilliamthornton@gmail.com> * Regenerate vtgate.pb.go proto file Signed-off-by: Thomas Thornton <thomaswilliamthornton@gmail.com> * Fix tests Signed-off-by: Thomas Thornton <thomaswilliamthornton@gmail.com> * Complete PR vitessio#18791 backport: Update metrics_cgroup.go Apply missing changes from PR vitessio#18791 to metrics_cgroup.go: - Replace cgroup1Manager and cgroup2Manager with single cgroupManager - Add errCgroupMetricsNotAvailable error variable - Add sync.Once for lazy initialization - Remove cgroup v1 support, only support cgroup v2 - Simplify implementation with unified cgroup manager This fixes compilation errors in metrics_cgroup_test.go. * Add missing github.com/containerd/cgroups dependency Required by metrics_cgroup.go for cgroup v1/v2 support. Signed-off-by: Thomas Thornton <thomaswilliamthornton@gmail.com> * Fix cgroups import to use v3 The v1 cgroups package is incompatible with Go 1.24.10. Use cgroups/v3 consistently throughout the file. Signed-off-by: Thomas Thornton <thomaswilliamthornton@gmail.com> * Fix goimports formatting Signed-off-by: Thomas Thornton <thomaswilliamthornton@gmail.com> --------- Signed-off-by: Thomas Thornton <thomaswilliamthornton@gmail.com>
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport these PRs for vstream/cdc
Related Issue(s)
Checklist
Deployment Notes
AI Disclosure