Skip to content

Comments

[slack-22.0] forward-fit: Allow setting grpc send and recv message sizes independe…#787

Merged
tanjinx merged 2 commits intoslack-22.0from
forward-port-grpc-config-slack
Feb 3, 2026
Merged

[slack-22.0] forward-fit: Allow setting grpc send and recv message sizes independe…#787
tanjinx merged 2 commits intoslack-22.0from
forward-port-grpc-config-slack

Conversation

@tanjinx
Copy link

@tanjinx tanjinx commented Feb 3, 2026

…ntly (#481) (#540)


  • remove vtgr

  • fix test

  • fix spaces


Description

forward-port:
#540

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

AI Disclosure

…ntly (#481) (#540)

* Allow setting grpc send and recv message sizes independently (#481)

* Allow setting grpc send and recv message sizes independently

Signed-off-by: Henry Robinson <hrobinson@slack-corp.com>

* Add comments

Signed-off-by: Henry Robinson <hrobinson@slack-corp.com>

* Update .txt files

Signed-off-by: Henry Robinson <hrobinson@slack-corp.com>

* update help txt ordering

Signed-off-by: Priya Bibra <pbibra@slack-corp.com>

---------

Signed-off-by: Henry Robinson <hrobinson@slack-corp.com>
Signed-off-by: Priya Bibra <pbibra@slack-corp.com>
Co-authored-by: Priya Bibra <pbibra@slack-corp.com>

* remove vtgr

* fix test

* fix spaces

---------

Signed-off-by: Henry Robinson <hrobinson@slack-corp.com>
Signed-off-by: Priya Bibra <pbibra@slack-corp.com>
Co-authored-by: Henry Robinson <hrobinson@slack-corp.com>
Co-authored-by: Priya Bibra <pbibra@slack-corp.com>
Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com>
@tanjinx tanjinx requested a review from a team as a code owner February 3, 2026 00:11
@github-actions github-actions bot added this to the v22.0.2 milestone Feb 3, 2026
Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com>
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 89.47368% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.75%. Comparing base (b1ab347) to head (48d83de).
⚠️ Report is 27 commits behind head on slack-22.0.

Files with missing lines Patch % Lines
go/vt/grpccommon/options.go 80.00% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##           slack-22.0     #787      +/-   ##
==============================================
+ Coverage       67.53%   69.75%   +2.22%     
==============================================
  Files            1600     1605       +5     
  Lines          261782   213624   -48158     
==============================================
- Hits           176786   149019   -27767     
+ Misses          84996    64605   -20391     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tanjinx tanjinx merged commit 1c15762 into slack-22.0 Feb 3, 2026
86 of 90 checks passed
@tanjinx tanjinx deleted the forward-port-grpc-config-slack branch February 3, 2026 01:51
sbaker617 pushed a commit that referenced this pull request Feb 5, 2026
…sizes independe… (#787)

* forward-fit: Allow setting grpc send and recv message sizes independently (#481) (#540)

* Allow setting grpc send and recv message sizes independently (#481)

* Allow setting grpc send and recv message sizes independently

Signed-off-by: Henry Robinson <hrobinson@slack-corp.com>

* Add comments

Signed-off-by: Henry Robinson <hrobinson@slack-corp.com>

* Update .txt files

Signed-off-by: Henry Robinson <hrobinson@slack-corp.com>

* update help txt ordering

Signed-off-by: Priya Bibra <pbibra@slack-corp.com>

---------

Signed-off-by: Henry Robinson <hrobinson@slack-corp.com>
Signed-off-by: Priya Bibra <pbibra@slack-corp.com>
Co-authored-by: Priya Bibra <pbibra@slack-corp.com>

* remove vtgr

* fix test

* fix spaces

---------

Signed-off-by: Henry Robinson <hrobinson@slack-corp.com>
Signed-off-by: Priya Bibra <pbibra@slack-corp.com>
Co-authored-by: Henry Robinson <hrobinson@slack-corp.com>
Co-authored-by: Priya Bibra <pbibra@slack-corp.com>
Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com>

* Remove accidentally committed vtgateproxy binary

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com>

---------

Signed-off-by: Henry Robinson <hrobinson@slack-corp.com>
Signed-off-by: Priya Bibra <pbibra@slack-corp.com>
Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com>
Co-authored-by: Henry Robinson <hrobinson@slack-corp.com>
Co-authored-by: Priya Bibra <pbibra@slack-corp.com>
Co-authored-by: Claude <svc-devxp-claude@slack-corp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants