vtgate: --keyspaces_to_watch allow globs like pitr*#793
Open
neil-harkins-sf wants to merge 1 commit intoslack-19.0from
Open
vtgate: --keyspaces_to_watch allow globs like pitr*#793neil-harkins-sf wants to merge 1 commit intoslack-19.0from
neil-harkins-sf wants to merge 1 commit intoslack-19.0from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Slack's
--keyspaces_to_watchcsv arguments can be quite long (many keyspaces), and in some cases they change often, currently requiring PRs to the config/framework which deploys and spawns vtgate processes.This PR allows any of those csv "keyspaces" to now contain an
*wildcard suffix/prefix which can match multiple keyspaces at vtgate startup time.Deployment Notes
Note that when a new keyspace is added which matches a glob, the vtgates will still have to be restarted to notice the new keyspace, but no change to the command line (usually requiring a PR) is not necessary.
AI Disclosure
This PR was written primarily by Claude Code