[slack-22.0] Add debug logging in reparent tests and disable replica offline/down tests for v19#794
Merged
tanjinx merged 5 commits intoslack-22.0from Feb 7, 2026
Merged
Conversation
Adds logging to capture error details when GetShardReplication fails during external reparent tests. This helps diagnose failures in TestReparentFromOutsideWithNoPrimary by showing the actual error message and command output. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com> Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## slack-22.0 #794 +/- ##
===========================================
Coverage 69.77% 69.78%
===========================================
Files 1605 1605
Lines 213999 213999
===========================================
+ Hits 149325 149340 +15
+ Misses 64674 64659 -15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com>
The test behavior changed in v20+. In v19 and below, PRS would fail when a cross-cell replica was offline. In v20+, PRS succeeds because it only requires same-cell tablets to be reachable with semi-sync durability. Skip this test for v19 and below to avoid test failures due to the behavior difference. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com> Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com>
The GetShardReplication command returns a nested JSON structure:
{
"shard_replication_by_cell": {
"zone1": {
"nodes": [...]
}
}
}
The assertNodeCount function was incorrectly looking for result["nodes"]
at the top level, causing a panic when trying to call Len() on a nil
reflect.Value. Updated to navigate the correct nested structure.
This fixes the panic in TestReparentFromOutside:
panic: reflect: call of reflect.Value.Len on zero Value
Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com>
The test behavior changed in v20+. In v19 and below, PRS would succeed when a same-cell replica MySQL was down. In v20+, PRS fails with an error because it verifies all tablets are reachable before proceeding. The test expects the v20+ behavior where PRS fails when a tablet is unreachable. Skip this test for v19 and below to avoid test failures. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com> Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com>
tanjinx
changed the title
slack-22.0] Add debug logging in reparent tests and disable TestReparentReplicaOffline and TestReparentWithDownReplica for v19
tanjinx
changed the title
slack-22.0] Add debug logging in reparent tests and disable TestReparentReplicaOffline and TestReparentWithDownReplica for v19slack-22.0] Add debug logging in reparent tests and disable replica offline/down tests for v19
yushuqin
approved these changes
Feb 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds logging to capture error details when GetShardReplication fails during external reparent tests. This helps diagnose failures in TestReparentFromOutsideWithNoPrimary by showing the actual error message and command output.
Description
Related Issue(s)
Checklist
Deployment Notes
AI Disclosure