fix: removing a (maybe unnecessary) upstream request on group emission#2032
Merged
jponge merged 1 commit intosmallrye:mainfrom Jan 7, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2032 +/- ##
============================================
- Coverage 89.18% 89.16% -0.03%
- Complexity 3120 3121 +1
============================================
Files 412 412
Lines 13295 13294 -1
Branches 1688 1688
============================================
- Hits 11857 11853 -4
- Misses 812 813 +1
- Partials 626 628 +2
🚀 New features to boost your workflow:
|
Member
|
It makes sense to me, I'd just add a test to make it obvious though 😃 |
Member
|
@ozangunalp Do you see how a test could be added? Otherwise LGTM |
cescoffier
approved these changes
Jan 7, 2026
Collaborator
Author
I think I did but forgot to push it :D let me look at it. |
each emitted item already requests upstream items
1a942f4 to
baef9fb
Compare
Collaborator
Author
|
I had modified the |
jponge
approved these changes
Jan 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
each emitted item already requests upstream items