Skip to content

fix: removing a (maybe unnecessary) upstream request on group emission#2032

Merged
jponge merged 1 commit intosmallrye:mainfrom
ozangunalp:less_upstream_request_group_by
Jan 7, 2026
Merged

fix: removing a (maybe unnecessary) upstream request on group emission#2032
jponge merged 1 commit intosmallrye:mainfrom
ozangunalp:less_upstream_request_group_by

Conversation

@ozangunalp
Copy link
Collaborator

each emitted item already requests upstream items

@codecov
Copy link

codecov bot commented Dec 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.16%. Comparing base (a1998df) to head (baef9fb).
⚠️ Report is 31 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #2032      +/-   ##
============================================
- Coverage     89.18%   89.16%   -0.03%     
- Complexity     3120     3121       +1     
============================================
  Files           412      412              
  Lines         13295    13294       -1     
  Branches       1688     1688              
============================================
- Hits          11857    11853       -4     
- Misses          812      813       +1     
- Partials        626      628       +2     
Files with missing lines Coverage Δ
...mallrye/mutiny/operators/multi/MultiGroupByOp.java 86.08% <ø> (-0.07%) ⬇️

... and 13 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jponge
Copy link
Member

jponge commented Dec 11, 2025

It makes sense to me, I'd just add a test to make it obvious though 😃

@jponge
Copy link
Member

jponge commented Jan 7, 2026

@ozangunalp Do you see how a test could be added? Otherwise LGTM

@ozangunalp
Copy link
Collaborator Author

It makes sense to me, I'd just add a test to make it obvious though 😃

I think I did but forgot to push it :D let me look at it.

each emitted item already requests upstream items
@ozangunalp ozangunalp force-pushed the less_upstream_request_group_by branch from 1a942f4 to baef9fb Compare January 7, 2026 09:07
@ozangunalp
Copy link
Collaborator Author

I had modified the testUpstreamRequestsNotBlownOutOfProportion test to check for the exact number of requests.

@jponge jponge merged commit f9a9091 into smallrye:main Jan 7, 2026
8 checks passed
@ozangunalp ozangunalp deleted the less_upstream_request_group_by branch January 7, 2026 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants