Skip to content

fix: mutiny-test-utils not test-scoped in some cases#2062

Merged
jponge merged 1 commit intosmallrye:mainfrom
Felk:test-utils-test-scope
Jan 31, 2026
Merged

fix: mutiny-test-utils not test-scoped in some cases#2062
jponge merged 1 commit intosmallrye:mainfrom
Felk:test-utils-test-scope

Conversation

@Felk
Copy link
Contributor

@Felk Felk commented Jan 30, 2026

This caused some test dependencies to unnecessarily ship into production code, which e.g. trips CVE scanners to flag assertj's CVE-2026-24400.

I didn't find any hints in the commit history indicating that this was on purpose.

Tests passed locally, except AssertSubscriberTest which tripped over LF vs CRLF since I ran them on Windows

This caused some test dependencies to unnecessarily ship into production code,
which e.g. trips CVE scanners to flag assertj's CVE-2026-24400
@codecov
Copy link

codecov bot commented Jan 31, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.10%. Comparing base (14e915d) to head (177be95).
⚠️ Report is 23 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #2062      +/-   ##
============================================
+ Coverage     89.00%   89.10%   +0.09%     
- Complexity     3115     3117       +2     
============================================
  Files           412      412              
  Lines         13296    13296              
  Branches       1687     1687              
============================================
+ Hits          11834    11847      +13     
+ Misses          822      820       -2     
+ Partials        640      629      -11     

see 12 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@jponge jponge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @Felk 👏

Thanks for the contribution!

@jponge jponge merged commit 10a9fdd into smallrye:main Jan 31, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants