Skip to content

Draft: fix: improve handling of missing revision fields in migration updates #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dwirz wants to merge 1 commit into
base: main
Choose a base branch
from
+26 −17
Open

Draft: fix: improve handling of missing revision fields in migration updates #408

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 26 additions & 17 deletions src/migrations/generate.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ import {
summonByName,
typeToField,
} from '../models/utils';
import { getColumnName } from '../resolvers';
import { Value } from '../values';

type Callbacks = (() => void)[];
Expand Down Expand Up @@ -546,23 +547,31 @@ export class MigrationGenerator {
});

// Insert data for missing revisions columns
this.writer
.write(`await knex('${model.name}Revision').update(`)
.inlineBlock(() => {
for (const { name, kind: type } of missingRevisionFields) {
const col = type === 'relation' ? `${name}Id` : name;
this.writer
.write(
`${col}: knex.raw('(select "${col}" from "${model.name}" where "${model.name}".id = "${
model.name
}Revision"."${typeToField(model.name)}Id")'),`,
)
.newLine();
}
})
.write(');')
.newLine()
.blankLine();
const revisionFieldsWithDataToCopy = missingRevisionFields.filter(
(field) =>
this.columns[model.name].find((col) => col.name === getColumnName(field)) ||
field.defaultValue !== undefined ||
field.nonNull,
);
if (revisionFieldsWithDataToCopy.length) {
this.writer
.write(`await knex('${model.name}Revision').update(`)
.inlineBlock(() => {
for (const { name, kind: type } of revisionFieldsWithDataToCopy) {
const col = type === 'relation' ? `${name}Id` : name;
this.writer
.write(
`${col}: knex.raw('(select "${col}" from "${model.name}" where "${model.name}".id = "${
model.name
}Revision"."${typeToField(model.name)}Id")'),`,
)
.newLine();
}
})
.write(');')
.newLine()
.blankLine();
}

const nonNullableMissingRevisionFields = missingRevisionFields.filter(({ nonNull }) => nonNull);
if (nonNullableMissingRevisionFields.length) {
Expand Down