chore!: Python and Go codegen runs in polymorph_code_gen target#688
Open
lucasmcdonald3 wants to merge 32 commits intomain-1.xfrom
Open
chore!: Python and Go codegen runs in polymorph_code_gen target#688lucasmcdonald3 wants to merge 32 commits intomain-1.xfrom
polymorph_code_gen target#688lucasmcdonald3 wants to merge 32 commits intomain-1.xfrom
Conversation
Contributor
|
@lucasmcdonald3 If you have the time, it would be great to also add Python to the It should be straightforward to add the |
polymorph_code_gen targetpolymorph_code_gen and clean targets
Contributor
Author
|
Putting this PR on ice until Go gets merged. This would create hiccups for Go that, ideally, we'd avoid for now. |
polymorph_code_gen and clean targetspolymorph_code_gen target
Contributor
ShubhamChaturvedi7
left a comment
There was a problem hiding this comment.
Changes look good, but let's wait till we have Go fully merged and has CI, which should be this week.
polymorph_code_gen targetpolymorph_code_gen target
Contributor
Author
|
Keeping this unmerged until Go ESDK is released. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes: Python and Go run as part of
polymorph_code_gen.Breaking change: The
dependency-library-nameCLI option has been removed. You must specify either/both of:python-dependency-module-namego-dependency-module-nameI have some downstream PRs open in Crypto Tools repos that use Python and/or Go codegen:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.