Merged
Conversation
…smithy-dafny into main-1.x
rishav-karanjit
requested changes
May 21, 2025
Member
rishav-karanjit
left a comment
rishav-karanjit
left a comment
There was a problem hiding this comment.
There are some typos which are blocking. Other then the typo it looks good to me.
codegen/smithy-dafny-codegen-cli/src/main/java/software/amazon/polymorph/CodegenCli.java
Outdated
Show resolved
Hide resolved
…mithy-lang/smithy-dafny into robin-aws/fix-nightly-build-2025-03-03
codegen/smithy-dafny-codegen-cli/src/main/java/software/amazon/polymorph/CodegenCli.java
Outdated
Show resolved
Hide resolved
…/polymorph/CodegenCli.java Co-authored-by: Rishav karanjit <karanjitrishav4@gmail.com>
robin-aws
added a commit
to aws/aws-cryptographic-material-providers-library
that referenced
this pull request
May 23, 2025
* Updated `smithy-dafny` to pick up the change to pass `--enforce-determinism` for newer Dafnies: smithy-lang/smithy-dafny#789 * Moved codgen CLI dependencies such as Java 17 into the common `install_smithy_dafny_codegen_dependencies/action.yml` workflow * Made workflows always call this action, since the shared makefile now calls the codegen CLI `if-dafny-at-least` command * Disabled checking formatting in the nightly, since that often hits false positives.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Code generation for Rust now requires
--enforce-determinismon Dafny master.Manual run of CI on Dafny master: https://github.com/smithy-lang/smithy-dafny/actions/runs/15166919294
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.