chore: improve rust blocking behavior#824
Merged
ajewellamz merged 8 commits intomain-1.xfrom Jan 23, 2026
Merged
Conversation
seebees
previously approved these changes
Jan 22, 2026
Contributor
seebees
left a comment
seebees
left a comment
There was a problem hiding this comment.
At a high level, this looks good to me.
mhelkey
reviewed
Jan 23, 2026
codegen/smithy-dafny-codegen/src/main/resources/templates/runtimes/rust/wrapped/client.rs
Show resolved
Hide resolved
robin-aws
requested changes
Jan 23, 2026
...en/src/main/java/software/amazon/polymorph/smithyrust/generator/RustAwsSdkShimGenerator.java
Outdated
Show resolved
Hide resolved
...en/src/main/java/software/amazon/polymorph/smithyrust/generator/RustAwsSdkShimGenerator.java
Outdated
Show resolved
Hide resolved
robin-aws
previously approved these changes
Jan 23, 2026
Contributor
robin-aws
left a comment
robin-aws
left a comment
There was a problem hiding this comment.
LGTM assuming we fix the missing CI checks and they pass :)
robin-aws
previously approved these changes
Jan 23, 2026
robin-aws
approved these changes
Jan 23, 2026
mhelkey
reviewed
Jan 23, 2026
| @@ -0,0 +1,27 @@ | |||
| async fn async_fn() { | |||
There was a problem hiding this comment.
Can these tests assert that ~100 milliseconds passed? Or some such assertion that the future was run to completion and not dropped
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.