Merged
Conversation
hpmellema
reviewed
Feb 19, 2025
hpmellema
reviewed
Feb 19, 2025
smithy-typescript-examples/quickstart-typescript/build.gradle.kts
Outdated
Show resolved
Hide resolved
yasmewad
reviewed
Feb 20, 2025
smithy-typescript-examples/quickstart-typescript/build.gradle.kts
Outdated
Show resolved
Hide resolved
haydenbaker
reviewed
Feb 20, 2025
smithy-typescript-examples/quickstart-typescript/build.gradle.kts
Outdated
Show resolved
Hide resolved
haydenbaker
reviewed
Feb 20, 2025
haydenbaker
reviewed
Feb 20, 2025
haydenbaker
reviewed
Feb 20, 2025
haydenbaker
suggested changes
Feb 20, 2025
Contributor
haydenbaker
left a comment
haydenbaker
left a comment
There was a problem hiding this comment.
You need to add the example to the templates file: https://github.com/smithy-lang/smithy-examples/blob/main/smithy-templates.json
haydenbaker
reviewed
Feb 20, 2025
Contributor
haydenbaker
left a comment
haydenbaker
left a comment
There was a problem hiding this comment.
Ran through the readme steps on my machine, nice work!
…, added ts example to smithy-templates.json
haydenbaker
approved these changes
Feb 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Add quick start example for smithy Typescript
Testing
smithy init --url /my/workplace/smithy-examples --template smithy-typescript-quickstartBy submitting this pull request, I confirm that my contribution is made under the terms of the MIT-0 license.