Fix cross-branch pollution bug in SchemaConverter recursion detection#841
Merged
adwsingh merged 1 commit intosmithy-lang:mainfrom Aug 8, 2025
Merged
Conversation
SchemaConverter would incorrectly identify member schemas as recursive when the shape graph contains multiple branches hitting the same target shape, downstream of the member shape. This change "pops" the "top of stack" shape on the way out of isRecursive(), avoiding this cross-branch pollution.
adwsingh
approved these changes
Aug 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
I did not file an issue.
Description of changes:
SchemaConverter would incorrectly identify member schemas as recursive when the shape graph contains multiple branches hitting the same target shape, downstream of the member shape.
This change "pops" the "top of stack" shape on the way out of isRecursive(), avoiding this cross-branch pollution.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.