Skip to content

added JDK8 compatibility for smithy-ai-traits#844

Merged
adwsingh merged 1 commit intosmithy-lang:mainfrom
yasmewad:jdk-8-ai-traits
Aug 12, 2025
Merged

added JDK8 compatibility for smithy-ai-traits#844
adwsingh merged 1 commit intosmithy-lang:mainfrom
yasmewad:jdk-8-ai-traits

Conversation

@yasmewad
Copy link
Contributor

@yasmewad yasmewad commented Aug 12, 2025

We want to be able to consume the traits package in JDK 8 packages too. Fixed JDK 8 compatibility in validator tests.

Testing:
./gradlew clean build

❯ javap -v 'jar:file:////Volumes/workplace/gateway-live/src/smithy-java/smithy-ai-traits/build/libs/smithy-ai-traits-0.0.2.jar!/software/amazon/smithy/ai/PromptsTrait.class' 'jar:file:////Volumes/workplace/gateway-live/src/smithy-java/smithy-ai-traits/build/libs/smithy-ai-traits-0.0.2.jar!/software/amazon/smithy/ai/PromptTemplateDefinition.class' | grep -B 2 "version:"
  Compiled from "PromptsTrait.java"
public final class software.amazon.smithy.ai.PromptsTrait extends software.amazon.smithy.model.traits.AbstractTrait implements software.amazon.smithy.utils.ToSmithyBuilder<software.amazon.smithy.ai.PromptsTrait>
  minor version: 0
  major version: 52
--
  Compiled from "PromptTemplateDefinition.java"
public final class software.amazon.smithy.ai.PromptTemplateDefinition extends java.lang.Object implements software.amazon.smithy.model.node.ToNode, software.amazon.smithy.utils.ToSmithyBuilder<software.amazon.smithy.ai.PromptTemplateDefinition>
  minor version: 0
  major version: 52

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@adwsingh adwsingh merged commit 04b4339 into smithy-lang:main Aug 12, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants