Add a plugin test runner and a test for types-codegen simple types#855
Merged
adwsingh merged 6 commits intosmithy-lang:mainfrom Aug 25, 2025
Merged
Conversation
sugmanue
force-pushed
the
sugmanue/add-codegen-plugin-test-runner
branch
from
13cdbf0 to
bdfab2d
Compare
adwsingh
requested changes
Aug 25, 2025
codegen/test-utils/src/main/java/software/amazon/smithy/java/codegen/test/PluginTestRunner.java
Outdated
Show resolved
Hide resolved
codegen/test-utils/src/main/java/software/amazon/smithy/java/codegen/test/PluginTestRunner.java
Outdated
Show resolved
Hide resolved
adwsingh
approved these changes
Aug 25, 2025
Comment on lines
+42
to
+43
| // Uncomment this test to render the java files when we there are changes to the codegen logic. | ||
| @ParameterizedTest(name = "[{index}] => {0}") @MethodSource("testCases") |
Contributor
There was a problem hiding this comment.
I think you meant to comment this.
Contributor
Author
There was a problem hiding this comment.
Yes, you're right. Let me fix that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
This change adds a utility class
PluginTestRunnerthat can be used by all codegen plugins to validate the code being generated.Also added a single test for the
TypeCodegenPlugin.The below issue was fixed in #856
This test shows a currently existing bug in the builders for nullable types, the setters are codegen to take primitive types which will make
.toBuilder()to fail if a nullable type is null and will make it impossible to update a member from a non-null value to a null one. E.g., this will fail:I will fix that issue after merging this change.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.