Exclude transfer-encoding header from sigv4(a) signing#3991
Exclude transfer-encoding header from sigv4(a) signing#3991landonxjames merged 1 commit intomainfrom
transfer-encoding header from sigv4(a) signing#3991Conversation
Add changelog
There was a problem hiding this comment.
LGTM. Existing integration tests for S3 capture the transfer-encoding header but I suspect they won't be broken since the way they verify expected results in tests is resilient to the changes in PR.
I am ok with leaving the transfer-encoding in connection recording tests; if we can create an issue for cleanup, that'd be great but keeping it around wouldn't be a blocker (please ignore that since the transfer-encoding in connection recording tests only appear in responses). Maybe want to quickly check (e.g., by using capture_request) that the transfer-encoding header is indeed excluded from an outgoing request.
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Looks like all of those should be able to stay since all of them appear in a Response and this change only impacts request signing. None of the |
Add changelog
Motivation and Context
Exclude
transfer-encodingheader from sigv4(a) signing. It is a hop by hop header and can be erased or modified by a proxy (in our particular case Cloudfront)Description
Testing
Updated the existing tests for excluded headers.
Checklist
.changelogdirectory, specifying "aws-sdk-rust" in theapplies_tokey.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.