publish codegen artifacts to maven central#4218
Merged
Conversation
d12b2b6 to
3d75fe4
Compare
landonxjames
approved these changes
Jul 23, 2025
Contributor
landonxjames
left a comment
There was a problem hiding this comment.
Overall looks good, couple of questions about the python/typescript bindings for the server, but those aren't blockers
| id("smithy-rs.publishing-conventions") | ||
| } | ||
|
|
||
| description = "Generates Rust/Python server-side code from Smithy models" |
Contributor
There was a problem hiding this comment.
I know we discussed not publishing the Typescript bindings, but I'm not terribly convinced that we should publish the Python bindings either. I guess people are using them? But my understanding is that support is pretty minimal
Contributor
Author
There was a problem hiding this comment.
Probably up to @drganjoo, I'm ok either way as these are all pre-GA versions for codegen with no backwards compat or stability guarantees.
Contributor
There was a problem hiding this comment.
Yes, Python is being used.
684ac71 to
74955f4
Compare
Contributor
Author
5c162bd to
cf5f52f
Compare
cf5f52f to
4d5e1c9
Compare
4d5e1c9 to
865d55c
Compare
drganjoo
approved these changes
Sep 9, 2025
ysaito1001
approved these changes
Sep 9, 2025
Contributor
ysaito1001
left a comment
There was a problem hiding this comment.
Awesome job on renaming & cleanup, also!
aajtodd
added a commit
that referenced
this pull request
Sep 10, 2025
## Description <!--- Describe your changes in detail --> #4218 broke the docker image build in a subtle way which is that we added Gradle build logic to `buildSrc` that is used in the root `build.gradle.kts` file. This wasn't found in PR:4218 because the docker build does a sparse checkout of the `main` branch which did not have the new logic/issue and thus was not triggered until after merging. ## Testing <!--- Please describe in detail how you tested your changes --> <!--- Include details of your testing environment, and the tests you ran to --> <!--- see how your change affects other areas of the code, etc. --> Local + CI build succeeds ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Publish codegen artifacts to Maven Central so users can generate Rust clients + servers without cloning smithy-rs and patching our build files.
Description
gradle.propertieshas been updated if any codegen project has changedcodegen-server/python->codegen-server/codegen-server-pythoncodegen-server/typescript->codegen-server/codegen-server-typescriptaws/sdk-codegen->aws/codegen-aws-sdkTODO
Need to decide on artifact names. We can probably live with most of them but the python/typescript artifacts don't indicate anything server specific and thesdk-codegenone doesn't indicate "AWS SDK" specific. Generally we don't publish the AWS SDK specific codegen but we tied up a lot of the "AWS specific" stuff like sigv in that module so seems like we might need to publish it as well for it to be of use. Open to discussion though.Need to finish configuring secretsPublish GPG keys, for some reason this is still not working I may need to switch machines to try it onComplete additional dry run release testingTesting
Checklist
.changelogdirectory, specifying "client," "server," or both in theapplies_tokey.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.