Conversation
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
ysaito1001
approved these changes
Aug 18, 2025
Contributor
ysaito1001
left a comment
There was a problem hiding this comment.
Nice!
Looks like it's successfully past where the previous dry-run failed
https://github.com/smithy-lang/smithy-rs/actions/runs/17045658453/job/48325493577#step:5:592
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding/fixing caching of Gradle wrapper to our build image increased it's size beyond 2GB. We started seeing issues with dry run release and download artifact silently failing. This PR attempts to optimize the image layers to reduce it's overall size and hopefully work past these issues.
Key Optimizations
Multi-stage consolidation:
• Combined all cargo tool installations into a single
cargo_toolsstage instead of separate stages per tool• Created dedicated
gradle_wrapperstage that reuses install_rust base to avoid duplicating Java installationLayer reduction:
• Combined RUN commands with cleanup operations (yum clean all && rm -rf /var/cache/yum)
• Added cargo cache cleanup (rm -rf /opt/cargo/registry/src && rm -rf /opt/cargo/git/db) after installations
• Consolidated AWS CLI installation and cleanup in single layer
Gradle wrapper optimization:
• Removed checkout_smithy_rs_tools conditional logic - now always fetches gradle wrapper
• Uses sparse checkout to fetch only required files (gradlew, gradle/wrapper, gradle.properties)
Before and after:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.