Conversation
- Add check-serde-codegen-unit-tests script - Add target to ci.mk - Add test to GitHub Actions workflow matrix
rcoh
force-pushed
the
add-codegen-serde-ci
branch
from
7c27019 to
7d85188
Compare
- tests failed to set `serialize_floats_as_strings` to true - wrong default for redact_sensitive_fields() - need an allow `unexected_cfgs`
rcoh
force-pushed
the
add-codegen-serde-ci
branch
from
074394a to
7a49712
Compare
rcoh
commented
Sep 23, 2025
| } | ||
|
|
||
| @Test | ||
| fun testRestJson() { |
Collaborator
Author
There was a problem hiding this comment.
this test is duplicated with the test below
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
ysaito1001
approved these changes
Sep 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the codegen-serde module to the GitHub Actions test matrix & fixes broken tests.
Along the way, I found some broken tests which I also fixed.
Changes
check-serde-codegen-unit-testsscript intools/ci-scripts/ci.mk.github/workflows/ci.ymlThis follows the same pattern as other codegen unit test modules (codegen-core, codegen-client, codegen-server) and ensures that codegen-serde tests are run as part of CI.